Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

captions - captions break if the vvt loaded contains a cue that has a forward slash in its text #3555

Closed
bcupac opened this issue Jul 28, 2021 · 0 comments · Fixed by #3556
Closed
Labels
status: archived Archived and locked; will not be updated

Comments

@bcupac
Copy link

bcupac commented Jul 28, 2021

Have you read the FAQ and checked for duplicate open issues?

What version of Shaka Player are you using?
3.2.0

Can you reproduce the issue with our latest release version?
yes

Can you reproduce the issue with the latest code from master?
yes

Are you using the demo app or your own custom app?
demo

If custom app, can you reproduce the issue using our demo app?

What browser and OS are you using?
chrome/macOS

For embedded devices (smart TVs, etc.), what model and firmware version are you using?

What are the manifest and license server URIs?

What configuration are you using? What is the output of player.getConfiguration()?

What did you do?

load a VTT file that contains a cue that has a forward slash(/) in its text

What did you expect to happen?
caption track would load and cues would show up

What actually happened?

an exception is thrown and captions break entirely

@bcupac bcupac mentioned this issue Jul 28, 2021
11 tasks
michellezhuogg pushed a commit that referenced this issue Aug 16, 2021
joeyparrish pushed a commit that referenced this issue Oct 12, 2021
joeyparrish pushed a commit that referenced this issue Oct 12, 2021
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Oct 15, 2021
@shaka-project shaka-project locked and limited conversation to collaborators Oct 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants