Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support alignment in CEA-608 #2940

Closed
avelad opened this issue Oct 26, 2020 · 7 comments · Fixed by #7022
Closed

Support alignment in CEA-608 #2940

avelad opened this issue Oct 26, 2020 · 7 comments · Fixed by #7022
Labels
component: captions/subtitles The issue involves captions or subtitles priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone
v4.11

Comments

@avelad
Copy link
Member

avelad commented Oct 26, 2020

According to #2731, positioning and alignment not supported.

This issue is to track additional support for this functionality.

Note: DASH-IF seems to have support for this functionality.
@TheModMaker TheModMaker added component: captions/subtitles The issue involves captions or subtitles type: enhancement New feature or request and removed needs triage labels Oct 26, 2020
@TheModMaker TheModMaker added this to the Backlog milestone Oct 26, 2020
@TheModMaker
Copy link
Contributor

Do you have any sample content that uses positioning?

@avelad
Copy link
Member Author

avelad commented Oct 26, 2020

@TheModMaker the streams of #2939 have positioning

@joeyparrish joeyparrish added the priority: P2 Smaller impact or easy workaround label Sep 29, 2021
@caridley
Copy link
Contributor

We need this as well, to prevent captions from covering important content like scores in sports programming.

@caridley
Copy link
Contributor

caridley commented Dec 1, 2021

This is a high priority for us, and we can help with implementation. We can provide access to streams for development purposes, but won't be able to provide long term access to those streams for use in regression testing or demo content.

It would be much appreciated if a Shaka developer with some expertise in the Shaka caption code could sketch out how this might be done in a way that is consistent with the existing architecture. Is this issue the appropriate place for that discussion?

@iskewedI
Copy link

Hi @avelad could you give me the status for this issue? I was about to open a new issue regarding CEA-608 captions that aren't being positioned correctly in the screen for TizenTV, and just found this. For the client the CC alignment is really important, so we need to confirm if you are going to support it.
Thank you!

@avelad
Copy link
Member Author

avelad commented Aug 29, 2022

The issue is still open, so we haven't worked on it yet. If you are interested in doing a PR for it, let us know. Thank you!

@avelad avelad mentioned this issue Aug 24, 2023
Merged
@avelad
Copy link
Member Author

avelad commented Aug 24, 2023

I added support to vertical position in #2940

avelad added a commit that referenced this issue Aug 25, 2023
@avelad
feat(CEA): Add support to vertical position in CEA-608 (#5531)
47224ff 
Related to #2940
@avelad avelad mentioned this issue Nov 24, 2023
Merged
avelad added a commit that referenced this issue Nov 27, 2023
@avelad
fix(CEA): Fix positioning in CEA-608 (#5925)
83f6f53 
See:
https://dvcs.w3.org/hg/text-tracks/raw-file/default/608toVTT/608toVTT.html#positioning-in-cea-608

Related to #2940
avelad added a commit that referenced this issue Nov 27, 2023
@avelad
fix(CEA): Fix positioning in CEA-608 (#5925)
bc2f542 
See:
https://dvcs.w3.org/hg/text-tracks/raw-file/default/608toVTT/608toVTT.html#positioning-in-cea-608

Related to #2940
Robloche pushed a commit to Robloche/shaka-player that referenced this issue Nov 30, 2023
@avelad
feat(CEA): Add support to vertical position in CEA-608 (shaka-project…
ed0a876 
…#5531)

Related to shaka-project#2940
Robloche pushed a commit to Robloche/shaka-player that referenced this issue Nov 30, 2023
@avelad
fix(CEA): Fix positioning in CEA-608 (shaka-project#5925)
2824d4f 
See:
https://dvcs.w3.org/hg/text-tracks/raw-file/default/608toVTT/608toVTT.html#positioning-in-cea-608

Related to shaka-project#2940
@avelad avelad changed the title Support for positioning and alignment CEA-608 Support alignment in CEA-608 Jun 24, 2024
@avelad avelad mentioned this issue Jul 11, 2024
Merged
@avelad avelad closed this as completed in 11a2cc5 Jul 12, 2024
@avelad avelad modified the milestones: Backlog, v4.11 Jul 24, 2024
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Sep 10, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Sep 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component: captions/subtitles The issue involves captions or subtitles priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v4.11
Development

Successfully merging a pull request may close this issue.

feat(CEA): Support alignment in CEA-608 avelad/shaka-player
6 participants
@TheModMaker @joeyparrish @caridley @avelad @shaka-bot @iskewedI