Skip to content

Commit

Permalink
ci: Fix Chrome failures on Mac VMs (#5509)
Browse files Browse the repository at this point in the history
  • Loading branch information
joeyparrish committed Aug 20, 2023
1 parent ae2ddd0 commit 98d794a
Showing 1 changed file with 15 additions and 0 deletions.
15 changes: 15 additions & 0 deletions .github/workflows/build-and-test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,21 @@ jobs:
# Install a launcher that can execute a shell script to launch this
npm install karma-script-launcher --save-dev
# When "Chrome for Testing" is installed on Mac, it gets invoked instead
# of simply "Chrome". This other copy of Chrome, however, doesn't seem
# to have basic codecs like AAC and H264 available, causing many of our
# test scenarios to fail. Deleting "Chrome for Testing" fixes this.
- name: 'Delete "Chrome for Testing" on Mac'
if: matrix.os == 'macos-latest' && matrix.browser == 'Chrome'
run: sudo rm -rf /Applications/Google\ Chrome\ for\ Testing.app

# Some CI images (self-hosted or otherwise) don't have the minimum Java
# version necessary for the compiler (Java 11).
- uses: actions/setup-java@v3
with:
distribution: zulu
java-version: 11

- name: Build Player
run: python build/all.py

Expand Down

0 comments on commit 98d794a

Please sign in to comment.