Fix box name extraction

shaka-project · Dec 1, 2022 · 93b6075 · 93b6075
1 parent 7e3edce
commit 93b6075
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/externs/shaka/mp4_parser.js b/externs/shaka/mp4_parser.js
@@ -11,6 +11,7 @@
 
 /**
  * @typedef {{
+ *    name: string,
  *    parser: !shaka.util.Mp4Parser,
  *    partialOkay: boolean,
  *    start: number,
@@ -21,6 +22,8 @@
  *    has64BitSize: boolean
  * }}
  *
+ * @property {string} name
+ *   The box name, a 4-character string (fourcc).
  * @property {!shaka.util.Mp4Parser} parser
  *   The parser that parsed this box. The parser can be used to parse child
  *   boxes where the configuration of the current parser is needed to parsed

diff --git a/lib/cea/mp4_cea_parser.js b/lib/cea/mp4_cea_parser.js
@@ -66,7 +66,7 @@ shaka.cea.Mp4CeaParser = class {
     const trackIds = [];
     const timescales = [];
 
-    const codecBoxParser = (box) => this.setBitstreamFormat_(box.type);
+    const codecBoxParser = (box) => this.setBitstreamFormat_(box.name);
 
     new Mp4Parser()
         .box('moov', Mp4Parser.children)

diff --git a/lib/util/mp4_parser.js b/lib/util/mp4_parser.js
@@ -172,6 +172,7 @@ shaka.util.Mp4Parser = class {
 
       /** @type {shaka.extern.ParsedBox} */
       const box = {
+        name,
         parser: this,
         partialOkay: partialOkay || false,
         version,