Skip to content

Commit

Permalink
ci: Fix demo index deployment (#4122)
Browse files Browse the repository at this point in the history
Fixes these issues with the demo index deployment (tested by manual deployment):

 - Missing `handlers:` field in app.yaml
 - Missing handler for the URL `/`
 - Missing Flask entrypoint (even though no dynamic content is generated by it)

Closes #4074
  • Loading branch information
joeyparrish authored Apr 12, 2022
1 parent 2eca4b2 commit 80e7f7b
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 1 deletion.
8 changes: 7 additions & 1 deletion app-engine/demo-version-index/app.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,13 @@
runtime: python39
default_expiration: 1h

# Serve the static/ folder directly.
handlers:
# Server static/index.html as the root.
- url: /
secure: always
static_files: static/index.html
upload: static/index.html
# Any other requests are served from the static/ folder.
- url: /(.+)
secure: always
static_files: static/\1
Expand Down
11 changes: 11 additions & 0 deletions app-engine/demo-version-index/main.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# Shaka Player Version Index - Appspot Entrypoint
# Copyright 2022 Google LLC
# SPDX-License-Identifier: Apache-2.0

# In the App Engine Python 3 runtime, you must have an entrypoint, even if all
# content is static and no routes are defined. This seems pretty weird, and
# wasn't required in the Python 2 runtime.

from flask import Flask

app = Flask(__name__)

0 comments on commit 80e7f7b

Please sign in to comment.