fix: mitigate uncaught type error in media_source_engine (#5069)

Fixes #4903
shaka-project · Apr 26, 2023 · 29a27cd · 29a27cd
1 parent 18e3c51
commit 29a27cd
Showing 1 changed file with 16 additions and 1 deletion.
diff --git a/lib/media/media_source_engine.js b/lib/media/media_source_engine.js
@@ -375,7 +375,22 @@ shaka.media.MediaSourceEngine = class {
               shaka.media.Transmuxer.convertCodecs(contentType, mimeType);
         }
         const type = mimeType + this.config_.sourceBufferExtraFeatures;
-        const sourceBuffer = this.mediaSource_.addSourceBuffer(type);
+
+        this.destroyer_.ensureNotDestroyed();
+
+        let sourceBuffer;
+
+        try {
+          sourceBuffer = this.mediaSource_.addSourceBuffer(type);
+        } catch (exception) {
+          throw new shaka.util.Error(
+              shaka.util.Error.Severity.CRITICAL,
+              shaka.util.Error.Category.MEDIA,
+              shaka.util.Error.Code.MEDIA_SOURCE_OPERATION_THREW,
+              exception,
+              'The mediaSource_ status was' + this.mediaSource_.readyState +
+              'expected \'open\'');
+        }
 
         this.eventManager_.listen(
             sourceBuffer, 'error',