Skip to content

Commit

Permalink
Fix storage cell constructor args
Browse files Browse the repository at this point in the history
When we changed the constructors for the V2 cells with the
introduction of V5 format, these call sites didn't get updated.  This
doesn't seem to be a user-facing bug, and did not affect any releases.

This was caught by a compiler upgrade.

Issue #2528

Change-Id: I77228d17631ef44a6b85a81b88054790461617bc
  • Loading branch information
joeyparrish committed Apr 28, 2020
1 parent 8867db6 commit 13202ce
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions lib/offline/indexeddb/storage_mechanism.js
Original file line number Diff line number Diff line change
Expand Up @@ -216,8 +216,7 @@ shaka.offline.indexeddb.StorageMechanism = class {
return new shaka.offline.indexeddb.V2StorageCell(
db,
segmentStore,
manifestStore,
true); // Are keys locked? Yes, this means no new additions.
manifestStore);
}
return null;
}
Expand All @@ -240,8 +239,7 @@ shaka.offline.indexeddb.StorageMechanism = class {
return new shaka.offline.indexeddb.V2StorageCell(
db,
segmentStore,
manifestStore,
false); // Are keys locked? No, this means we can add new entries.
manifestStore);
}
return null;
}
Expand Down

0 comments on commit 13202ce

Please sign in to comment.