Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix clang build #1288

Merged
merged 1 commit into from
Oct 18, 2023
Merged

fix: Fix clang build #1288

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packager/third_party/abseil-cpp/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,15 @@ endif()

# With these set in scope of this folder, load the library's own CMakeLists.txt.
add_subdirectory(source)

# Clang builds of absl::time fail due to the inclusion of -Wconversion without
# -Wno-implicit-int-conversion. However, we can't add that with
# add_compile_options beforehand, because those flags go in before absl's
# -Wconversion flag gets added. We can, however, add
# -Wno-implicit-int-conversion to each necessary target after it is defined.
# This will append after absl's own flags.
if(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
target_compile_options(absl_civil_time PUBLIC -Wno-implicit-int-conversion)
target_compile_options(absl_time PUBLIC -Wno-implicit-int-conversion)
target_compile_options(absl_time_zone PUBLIC -Wno-implicit-int-conversion)
endif()