Skip to content

Commit

Permalink
fix(shaka-lab-github-runner): Fix service restart logic (#59)
Browse files Browse the repository at this point in the history
We should always try to restart these runners, but the systemd config
for that was unclear. This fixes the service logic to never give up on
restarting the service.

We had a transient error in authentication to GitHub that took down
15/16 runner services. Once they reached their start limit, they stopped
completely in a failed state.

With this configuration, that would not have happened. Eventually, they
all would have come back up.
  • Loading branch information
joeyparrish authored Sep 3, 2024
1 parent 78d867f commit a1fd900
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions shaka-lab-github-runner/linux/[email protected]
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,14 @@ Requires=docker.service
PartOf=shaka-lab-github-runners.target

[Service]
# Wait this long for the service to start up (0 disables timeouts)
TimeoutStartSec=0
# Always restart (meaning under all exit conditions, still limited in number
# by StartLimit* options)
Restart=always
# Wait this long before restarting
RestartSec=30s
# This removes any limit on the number of retries
StartLimitInterval=0
# What to start
ExecStart=/opt/shaka-lab/shaka-lab-github-runner/start-runner.sh %i

0 comments on commit a1fd900

Please sign in to comment.