fix: Fix ChromeHeadless in Docker #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyparrish
approved these changes
Jul 19, 2023
joeyparrish
changed the title
|
Thank you very much! I'll be releasing an update here shortly, then I'll bump the dep in Shaka Player after that. |
joeyparrish
pushed a commit
that referenced
this pull request
Jul 19, 2023
🤖 I have created a release *beep* *boop* --- ## [1.6.2](v1.6.1...v1.6.2) (2023-07-19) ### Bug Fixes * Fix ChromeHeadless in Docker ([#51](#51)) ([a487e6d](a487e6d)) * Fix clobbering of arguments in custom configurations ([#50](#50)) ([43ce270](43ce270)) * Fix failure when drivers lag behind browser ([#53](#53)) ([14cf6c3](14cf6c3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently ChromeHeadless cannot be run in the Docker environment due to lack of
--no-sandboxargument. Trying to run ChromeHeadless within Docker ends withDevToolsActivePort file doesn't existerror. You can find more info here: https://bugs.chromium.org/p/chromedriver/issues/detail?id=2473EDIT: of course this can be omitted by creating custom launcher, but I believe this can be so common issue it's better to tackle it by default. Additionally I'm planning to add running tests within Docker to shaka, so it'll easify process.