Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix clobbering of arguments in custom configurations #50

Merged
merged 3 commits into from
Jul 19, 2023
Merged

fix: Fix clobbering of arguments in custom configurations #50

merged 3 commits into from
Jul 19, 2023

Conversation

tykus160
Copy link
Member

Properly merge arrays when custom configuration is used, so i.e. ChromeHeadless now can be extended with additional args:

customLaunchers: {
  'ChromeHeadlessNoSandbox': {
    base: 'ChromeHeadless',
    config: {
      'goog:chromeOptions': {
        args: [
          '--no-sandbox',
          // before we had to pass other args because merge wasn't working properly
          // '--headless',
          // '--disable-gpu',
          // '--disable-dev-shm-usage',
        ],
      },
    },
  },
},

@joeyparrish joeyparrish changed the title fix: merge arrays properly fix: Fix clobbering of arguments in custom configurations Jul 19, 2023
@joeyparrish joeyparrish merged commit 43ce270 into shaka-project:main Jul 19, 2023
@joeyparrish
Copy link
Member

Thank you for your contribution!

@github-actions github-actions bot mentioned this pull request Jul 19, 2023
Merged
joeyparrish pushed a commit that referenced this pull request Jul 19, 2023
@github-actions
chore(main): release 1.6.2 (#52)
8a1890e 
🤖 I have created a release *beep* *boop*
---


##
[1.6.2](v1.6.1...v1.6.2)
(2023-07-19)


### Bug Fixes

* Fix ChromeHeadless in Docker
([#51](#51))
([a487e6d](a487e6d))
* Fix clobbering of arguments in custom configurations
([#50](#50))
([43ce270](43ce270))
* Fix failure when drivers lag behind browser
([#53](#53))
([14cf6c3](14cf6c3))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
joeyparrish added a commit to joeyparrish/shaka-player that referenced this pull request Jul 29, 2023
@joeyparrish
ci: Refactor and update Shaka lab definitions
8e0f353 
 - In karma.conf.js, give ourselves the ability to merge Selenium
   configs together without clobbering argument lists, for better
   deduplication in shaka-lab.yaml.  This is based on
   shaka-project/karma-local-wd-launcher#50
 - Refactor shaka-lab.yaml to take advantage of this new ability.  This
   removes a bunch of duplicate command line arguments for various
   versions of Chrome.
 - Remove a TODO about a bug that Chrome decided they would never fix.
 - Sort the list of devices and platforms, with comments to mark out the
   sections.
 - Remove IE11, which we are well past supporting or testing.

This should be cherry-picked to all active branches.
@joeyparrish joeyparrish mentioned this pull request Jul 29, 2023
Merged
joeyparrish added a commit to shaka-project/shaka-player that referenced this pull request Jul 31, 2023
@joeyparrish
ci: Refactor and update Shaka lab definitions (#5449)
ace3e37 
- In karma.conf.js, give ourselves the ability to merge Selenium configs together without clobbering argument lists, for better deduplication in shaka-lab.yaml.  This is based on shaka-project/karma-local-wd-launcher#50
 - Refactor shaka-lab.yaml to take advantage of this new ability.  This removes a bunch of duplicate command line arguments for various versions of Chrome.
 - Remove a TODO about a bug that Chrome decided they would never fix.
 - Sort the list of devices and platforms, with comments to mark out the sections.
 - Remove IE11, which we are well past supporting or testing.

This should be cherry-picked to all active branches.
joeyparrish added a commit to shaka-project/shaka-player that referenced this pull request Aug 19, 2023
@joeyparrish
ci: Refactor and update Shaka lab definitions (#5449)
6c15143 
- In karma.conf.js, give ourselves the ability to merge Selenium configs together without clobbering argument lists, for better deduplication in shaka-lab.yaml.  This is based on shaka-project/karma-local-wd-launcher#50
 - Refactor shaka-lab.yaml to take advantage of this new ability.  This removes a bunch of duplicate command line arguments for various versions of Chrome.
 - Remove a TODO about a bug that Chrome decided they would never fix.
 - Sort the list of devices and platforms, with comments to mark out the sections.
 - Remove IE11, which we are well past supporting or testing.

This should be cherry-picked to all active branches.
joeyparrish added a commit to shaka-project/shaka-player that referenced this pull request Aug 20, 2023
@joeyparrish
ci: Refactor and update Shaka lab definitions (#5449)
7b0f5dd 
- In karma.conf.js, give ourselves the ability to merge Selenium configs together without clobbering argument lists, for better deduplication in shaka-lab.yaml.  This is based on shaka-project/karma-local-wd-launcher#50
 - Refactor shaka-lab.yaml to take advantage of this new ability.  This removes a bunch of duplicate command line arguments for various versions of Chrome.
 - Remove a TODO about a bug that Chrome decided they would never fix.
 - Sort the list of devices and platforms, with comments to mark out the sections.
 - Remove IE11, which we are well past supporting or testing.

This should be cherry-picked to all active branches.
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Sep 17, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joeyparrish joeyparrish joeyparrish approved these changes

Assignees
No one assigned
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tykus160 @joeyparrish