Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Safari doesn't always shut down properly #24

Closed
joeyparrish opened this issue Feb 17, 2022 · 2 comments · Fixed by #38 or #40
Closed

Safari doesn't always shut down properly #24

joeyparrish opened this issue Feb 17, 2022 · 2 comments · Fixed by #38 or #40
Assignees
@joeyparrish
Labels
browser: Safari Issues affecting Safari or WebKit derivatives platform: macOS Issues affecting macOS status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
Backlog

Comments

@joeyparrish
Copy link
Member

The Safari tests for Shaka Player in GitHub Actions seem to succeed, but the job doesn't shut down properly and eventually times out after ~6h. This seems likely to be a bug in the launcher.
@joeyparrish joeyparrish added type: bug Something isn't working correctly platform: macOS Issues affecting macOS browser: Safari Issues affecting Safari or WebKit derivatives labels Feb 17, 2022
@joeyparrish joeyparrish self-assigned this Feb 17, 2022
@joeyparrish joeyparrish mentioned this issue Feb 17, 2022
Closed
@joeyparrish
Copy link
Member Author

See also shaka-project/shaka-player#3967

@joeyparrish
Copy link
Member Author

Logs from such a test run:

5_Test Player.txt

@github-actions github-actions bot added this to the v2 milestone Feb 23, 2022
@joeyparrish joeyparrish removed this from the v2 milestone Feb 24, 2022
@github-actions github-actions bot added this to the Backlog milestone Feb 24, 2022
@joeyparrish joeyparrish mentioned this issue Apr 20, 2022
Merged
joeyparrish added a commit that referenced this issue Apr 20, 2022
@joeyparrish
fix: Fix hung launcher on shutdown of Safari (#38)
adc7898 
In some cases (notably macOS Safari under GitHub Actions), a call to
forceKill() would be triggered during another call to forceKill().
This could cause the second Promise to go unresolved, leading to a
hang.  On GitHub, eventually, the workflow would be cancelled.

This fixes the nested calls to forceKill by making them both resolve
on the same event (the shutdown triggered by the first call).

This also adds a timeout for shutting down a WebDriver session.
Although this does not appear to be the root cause of the hang we
were experiencing in GitHub Actions workflows, it should be safer to
have this timeout.  If we can't stop a WebDriver session gracefully,
we will timeout after 5s and end the launcher anyway.

Closes #24
@github-actions github-actions bot mentioned this issue Apr 20, 2022
Merged
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jun 20, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joeyparrish joeyparrish

Labels
browser: Safari Issues affecting Safari or WebKit derivatives platform: macOS Issues affecting macOS status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
Backlog
1 participant
@joeyparrish