fix(chromecast): Speed up shutdown #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After we launch the requested receiver app, we should shut down the connection explicitly. Otherwise, it has to time out before the calling application in nodejs can terminate.
alekzz
reviewed
Sep 11, 2023
alekzz
approved these changes
Sep 14, 2023
joeyparrish
pushed a commit
that referenced
this pull request
Sep 15, 2023
🤖 I have created a release *beep* *boop* --- ## [1.2.0](chromecast-webdriver-server-v1.1.1...chromecast-webdriver-server-v1.2.0) (2023-09-15) ### Features * **chromecast:** Support Google Pixel Tablet ([#77](#77)) ([6cf553e](6cf553e)) ### Bug Fixes * **chromecast:** Speed up shutdown ([#78](#78)) ([89f4146](89f4146)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After we launch the requested receiver app, we should shut down the connection explicitly. Otherwise, the socket has to time out before the calling application in nodejs can terminate. This is because nodejs keeps the main thread running so long as anything async could occur, including events on handles and sockets.