Skip to content

Commit

Permalink
fix: Document change detector breaking change (sourcenetwork#1531)
Browse files Browse the repository at this point in the history
## Relevant issue(s)

Resolves sourcenetwork#1530 

## Description

This PR fixes the previous fix and adds a breaking change document to
prevent the broken cycle in the change detector after the fix. Should
have been part of the sourcenetwork#1528 although the change detector was passing
before merge.
  • Loading branch information
fredcarle authored May 25, 2023
1 parent 55fabe3 commit 89591fd
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# Change detector without non-mutations actions

The previous fix caused a regression in the change detector and we need a documentation to break the cycle.
3 changes: 1 addition & 2 deletions tests/integration/utils2.go
Original file line number Diff line number Diff line change
Expand Up @@ -549,8 +549,6 @@ ActionLoop:
} else if firstNonSetupIndex > -1 {
// -1 to exclude this index
endIndex = firstNonSetupIndex - 1
} else {
startIndex = endIndex
}
} else {
if setupCompleteIndex > -1 {
Expand All @@ -560,6 +558,7 @@ ActionLoop:
// We must not set this to -1 :)
startIndex = firstNonSetupIndex
} else {
// if we don't have any non-mutation actions, just use the last action
startIndex = endIndex
}
}
Expand Down

0 comments on commit 89591fd

Please sign in to comment.