Merge pull request #22 from shafayetShafee/fix-#20

Fixed #20
shafayetShafee · May 10, 2024 · 9e449ec · 9e449ec
2 parents 5ff1a31 + b8d9fbe
commit 9e449ec
Show file tree

Hide file tree

Showing 12 changed files with 330 additions and 142 deletions.
diff --git a/README.md b/README.md
@@ -126,3 +126,8 @@ Also, to change the header text style for slides with simple [`background`](http
 - The source code for another example that uses only `sc-sb-title`: [example_section-title.qmd](example_section-title.qmd) and the live demo of the rendered revealjs slides, [`example_section_title.html`](https://shafayetshafee.github.io/reveal-header/example_section_title.html)
 
 - The source code for example where header text is hidden on the title slide: [example_hide_header_text.qmd](example_hide_header_text.qmd) and the [`rendered output`](https://shafayetshafee.github.io/reveal-header/example_hide_header_text.html)
+
+
+## Similar Extension
+
+If you find this extension useful, you may also like [`metropolis-beamer`](https://github.com/shafayetShafee/metropolis-beamer/tree/main) extension that provides a custom quarto revealjs format which aims to provide a lookalike [`metropolis beamer theme`] for quarto revealjs.
diff --git a/_extensions/reveal-header/_extension.yml b/_extensions/reveal-header/_extension.yml
@@ -1,6 +1,6 @@
 title: Reveal-header
 author: Shafayet Khan Shafee
-version: 1.2.7
+version: 1.2.8
 quarto-required: ">=1.2.0"
 contributes:
   filters:

diff --git a/_extensions/reveal-header/resources/css/add_header.css b/_extensions/reveal-header/resources/css/add_header.css
@@ -35,6 +35,7 @@
 .reveal-header.no-logo .sc-title p {margin-left: 6vw}
 
 
+.reveal .header-logo svg,
 .reveal .header-logo img {
   margin: var(--header-margin);
   padding-left: 1vw;
@@ -46,6 +47,8 @@
 }
 
 
+
+
 /* .reveal .slides { margin-top: 3vh !important;} */
 .inverse-header { color: #c5d7ce !important;}
 

diff --git a/_extensions/reveal-header/resources/js/add_header.js b/_extensions/reveal-header/resources/js/add_header.js
@@ -15,10 +15,10 @@ function header() {
     reveal.insertBefore(header, reveal.firstChild);
 
     logo_img = document.querySelector('.header-logo img');
-    if (logo_img.getAttribute('src') == null) {
+    if (logo_img?.getAttribute('src') == null) {
       if (logo_img?.getAttribute('data-src') != null) {
         logo_img.src = logo_img?.getAttribute('data-src') || "";
-        logo_img.removeAttribute('data-src'); 
+        logo_img?.removeAttribute('data-src'); 
       };
     };
   };
@@ -86,12 +86,12 @@ function header() {
       const footer_logo_link = get_clean_attrs(header_logo, 'data-footer-logo-link');
 
       if (header_logo_link != null) {
-        const header_logo_img = document.querySelector('div.header-logo img');
+        const header_logo_img = document.querySelector('div.header-logo').firstElementChild;
         linkify_logo(header_logo_img, header_logo_link);
       };
 
       if (footer_logo_link != null) {
-        const footer_logo_img = document.querySelector('img.slide-logo');
+        const footer_logo_img = document.querySelector('.slide-logo');
         footer_logo_img.setAttribute('style', "z-index:99;");
         linkify_logo(footer_logo_img, footer_logo_link);
       };

diff --git a/_extensions/reveal-header/resources/js/sc_sb_title.js b/_extensions/reveal-header/resources/js/sc_sb_title.js
@@ -39,7 +39,7 @@
 
   if (Reveal.isReady()) {
 
-    if (document.querySelector('div.reveal-header img').getAttribute('src').length == 0) {
+    if (document.querySelector('div.reveal-header img')?.getAttribute('src')?.length == 0) {
       document.querySelector('div.reveal-header').classList.add('no-logo')
     }
 

diff --git a/docs/example.html b/docs/example.html
diff --git a/docs/example_all.html b/docs/example_all.html
diff --git a/docs/example_hide_header_text.html b/docs/example_hide_header_text.html
diff --git a/docs/example_section_title.html b/docs/example_section_title.html
diff --git a/open_html_files.sh b/open_html_files.sh
diff --git a/test_examples.sh b/test_examples.sh
diff --git a/testing.sh b/testing.sh
@@ -51,7 +51,7 @@ case "$argument" in
     mv *.html docs/
     echo "Opening HTML files from docs folder"
     for html_file in docs/*.html; do
-      start "$html_file"
+      open "$html_file"
     done
     ;;
   "help")