Fix shadowsocks/shadowsocks-android#2562

[madeye]

Fix shadowsocks/shadowsocks-android#2562

[Mygod]

The latest openssl 0.10.30 pakcage requires a minimal SDK target 23

Why is this?

Also there is a better fix imo for this.

[zonyitoo]

The latest openssl 0.10.30 pakcage requires a minimal SDK target 23

That's bad.. :(

[Mygod]

shadowsocks/shadowsocks-android@0d75659

We should try to find a fix for 0.10.30 as well. Perhaps the new prefab thing? https://android-developers.googleblog.com/2020/02/native-dependencies-in-android-studio-40.html

[madeye]

Maybe we just increase the minSDK to 23...

[Mygod]

Where did you find the information regarding minSDK?

[RebelliousWhiz]

I don't know what's impacting the code, but to my perspective, people still use SDK 23 devices don't care about GFW.... My grandma has a MI 6, and it's now on Android 10...

I guess it's completely fine to set minSDK to 23.

[Mygod]

Reported to upstream: sfackler/rust-openssl#1315

If we do not get a satisfactory fix we can drop support for Android 5. (openssl updates > legacy Android support)

[zonyitoo]

So, is it ok for me to merge this MR? @Mygod

[Mygod]

I don't think we need this merged for now.

[madeye]

I think the missing part is how to pass VPN option to plugins, which is not defined before.

Maybe we should fix this from plugin's side instead.

[Mygod]

So let's settle this once and for all: what should we use? -V or V in plugin options.

[zonyitoo]

Since SS_PLUGIN_OPTIONS is defined as "options for plugin", the VPN flag should be passed in options.

Some programs will exit immediately if it meets unrecognized arguments, which is why I don't think it is a good idea to implicitly add -V for all plugins.

BTW, v2ray-plugin supports vpn in option: https://github.com/shadowsocks/v2ray-plugin/blob/master/main.go#L332-L334 .

I propose vpn in plugin options instead of V in plugin options or -V in program arguments, which has more precise meaning than V. V means a lot of things, version, verbose, ...

[zonyitoo]

Or maybe we can define a new environment variable, such as SS_PLUGIN_CTRL, which could be used for passing standardized controlling options, like vpn_mode=1&verbose=3&fast_open=1

[madeye]

Let's put V into the SS_PLUGIN_OPTIONS. I'll release a new v2ray-plugin to ensure the VPU flags is parsed correctly.

[madeye]

Fixed via shadowsocks/v2ray-plugin-android@4788843

[Mygod]

Should we get rid of this hack then?

shadowsocks-rust/src/plugin/ss_plugin.rs

Line 28 in efd9e77

if opt.contains(";V") {

[madeye]

Yep, let's remove that hack.