Set the incoming socket buffer sizes properly on the listen socket. #1381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notsure2
force-pushed
the
fix-incoming-socket-buffer-size-handling
branch
from
0d53cf2
to
23c4336
Compare
zonyitoo
reviewed
Dec 14, 2023
notsure2
force-pushed
the
fix-incoming-socket-buffer-size-handling
branch
from
23c4336
to
9afd670
Compare
|
@zonyitoo there you go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incoming buffer sizes are read by config but not actually set on the socket.
tokio TcpSocket gained the ability finally to set this.
This PR sets the incoming socket buffer snd/rcv buffer on the TcpSocket in a cross platform manner.