Visibility of methods in shadowsocks

[botylev]

Hello,

I'm building my own personal proxy tool and would like to use the existing shadowsocks-rust project as a library.
I faced a small problem with a function in ProxyServerStream::from_stream - it is marked as pub(crate) and therefore I cannot reuse it in my code. I know about ProxyListener built in shadowsocks crate but I would really prefer to use ProxyServerStream with already accepted TcpStream from Tokio because it is more convenient to work with in my application context.

Can you please elaborate on pub(crate) visibility on this method? Can it be done just like pub?

Also I would like to mention CryptoStream::set_request_nonce_with_received and CryptoStream::current_data_chunk_remaining because they are also marked as pub(crate) and I think they can be just pub.

Thanks

[zonyitoo]

Make them public means that I have to maintain API compatibility in the future upgrades, but they are really should not being considered as "stable" APIs.

[botylev]

I see that ProxyClientStream::from_stream is public, so you maintain compatibility for this method but not for server side variant? Is there any particular reason for that? Thanks

[zonyitoo]

Well, because the Server stream can only be built by Listener, so it doesn't need to be public. The Client stream's from_stream was used in the service crate so it has to be public.

I am Ok to make Server stream's from_stream public, but the user_manager shouldn't be there because it is not a required attribute, which should be set with a setter.

[botylev]

Thank you very much, that will be enough for me.