Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: support macOS's launch_activate_socket #1330

Closed
liudongmiao opened this issue Oct 19, 2023 · 3 comments · Fixed by #1332
Closed

feature request: support macOS's launch_activate_socket #1330

liudongmiao opened this issue Oct 19, 2023 · 3 comments · Fixed by #1332

Comments

@liudongmiao
Copy link
Contributor

In shadowsocks-libev, there is launch_activate_socket in shadowsocks/shadowsocks-libev#1003.
In shadowsocks-rust, there is no such feature.

So, it's possible for shadowsocks-rust to support this feature?

There is another rust project https://github.com/LinkTed/doh-client ships with launch_activate_socket.

@zonyitoo
Copy link
Collaborator

It seems that you only create the TCP socket via launch_activate_socket, how about the UDP socket?

@zonyitoo
Copy link
Collaborator

zonyitoo commented Oct 19, 2023

https://github.com/LinkTed/doh-client/blob/master/src/listen/activation_socket.rs#L28-L34

It has memory leaks if launch_activate_socket returns cnt > 1.

@liudongmiao
Copy link
Contributor Author

@zonyitoo I will try to implement and make a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants