-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support non-standard extra algorithms #8
Comments
for |
Instead of adding rarely-used algorithms without changing the protocol, maybe we should turn our focus to implementing one of our proposed draft protocols. |
Agreed but that's offtopic here. Open another issue to track it. |
I don't think so. So it the safest way is to use the libsodium's implementation. |
- Enable new ciphers with v1-aead-extra - Support xchacha20-ietf-poly1305 with libsodium fixes #8
- Enable new ciphers with v1-aead-extra - Support xchacha20-ietf-poly1305 with libsodium fixes #8
- Enable new ciphers with v1-aead-extra - Support xchacha20-ietf-poly1305 with libsodium fixes #8
- Enable new ciphers with v1-aead-extra - Support xchacha20-ietf-poly1305 with libsodium fixes #8
- Enable new ciphers with v1-aead-extra - Support xchacha20-ietf-poly1305 with libsodium fixes #8
- Enable new ciphers with v1-aead-extra - Support xchacha20-ietf-poly1305 with libsodium fixes #8
* Support non-standard AEAD ciphers with feature v1-aead-extra - Enable new ciphers with v1-aead-extra - Support xchacha20-ietf-poly1305 with libsodium fixes #8 * crypto2 has removed Zeroize - release version 0.2.1 * switched to self implemented xchacha20-ietf-poly1305 Co-authored-by: luozijun <[email protected]>
- updated crypto2 to 0.1.2 - support AEAD extra ciphers with aead-cipher-extra - fixes shadowsocks/shadowsocks-android#2663 - ref shadowsocks/shadowsocks-crypto#8
- updated crypto2 to 0.1.2 - support AEAD extra ciphers with aead-cipher-extra - fixes shadowsocks/shadowsocks-android#2663 - ref shadowsocks/shadowsocks-crypto#8
- updated crypto2 to 0.1.2 - support AEAD extra ciphers with aead-cipher-extra - fixes shadowsocks/shadowsocks-android#2663 - ref shadowsocks/shadowsocks-crypto#8
Background
Algorithms that are already supported by
crypto2
:aes-128-ccm
,aes-256-ccm
aes-128-gcm-siv
,aes-256-gcm-siv
aes-128-ocb-taglen128
,aes-192-ocb-taglen128
,aes-256-ocb-taglen128
aes-siv-cmac-256
,aes-siv-cmac-384
,aes-siv-cmac-512
Algorithms that are the most wanted in other implementations:
xchacha20-ietf-poly1305
(libsodium
), like Request for restoring the deprecated AEAD cipher "XChaCha20-Poly1305-IETF" shadowsocks-android#2663Some algorithms that are not implemented yet:
sm4-gcm
sm4-ccm
These algorithms are not standardized by shadowsocks' community, but it is still possible to enable these by optional features.
Proposal
Add an optional feature
v1-aead-extra
to enable all the extra algorithms described above.Notice:
xchacha20-ietf-poly1305
doesn't have a standardized specification about its technical detail, so we have to use its original and the only implementation inlibsodium
. This may significantly increase the output binary size.The text was updated successfully, but these errors were encountered: