-
-
Notifications
You must be signed in to change notification settings - Fork 11.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Service is down intermittently #2667
Comments
It looks related to But I guess it's not the root cause. Two questions:
|
Looping @zonyitoo in on this.
|
Couldn't reproduce because I don't possess an Android device. :( Anything I can help? Maybe start |
@zonyitoo You can try this on a router with local DNS feature enabled. I guess it's something related to socket leaks. |
@Mygod please try change shadowsocks-android/core/src/main/java/com/github/shadowsocks/bg/ProxyInstance.kt Line 85 in 1394ab3
|
I tested with while true; do dig @127.0.0.1 -p 5300 google.com; done and runs |
BTW, |
After testing for hours, I still cannot reproduce the problem locally. There's no socket leaks observed, even with intensive VoIP usage. I'm watching the open FDs through ADB:
|
For more context, I have been using it with VPN hotspot, which forwards other DNS packets via NAT. I will do more test later. |
Just got a different error: |
UDP packet didn't have a SOCKS5 header: https://github.com/shadowsocks/shadowsocks-rust/blob/master/crates/shadowsocks-service/src/local/socks/server/socks5/udprelay.rs#L110-L118
And it is obviously a plain DNS query. |
Ok I ran libsslocal with
|
It looks we need to check the VPNService Seems |
There is no significant network related logic change in Kotlin since my last update: v5.1.7...1394ab3 I am pretty sure that I was on v5.1.7 before, and it was able to run completely fine for a long period of time. |
Yes, I mean the protect logic in |
|
Just to confirm, you cannot visit https://1.1.1.1 after the |
I have not tried 1.1.1.1 specifically but ssh into an IP directly does not work. |
Regarding this, it only happens randomly. Perhaps try to run it more? |
@zonyitoo I'm reviewing Do we have logic to handle timeout like this? https://github.com/shadowsocks/shadowsocks-libev/blob/cfe0c2cba08f25e5a70294b368490f66032ac882/src/android.c#L63 |
@Mygod I usually switch profiles from time to time, maybe that's why I didn't observe connection down before. Also, unlike tethering, workload from one phone is typically lower, making me harder to reproduce the issue. |
One more question for @Mygod, do you observe busy CPU usage when the connection down? |
There are only CONNECT related items in @Mygod's logs, no DNS logs, as he is running in |
Async I/O doesn't have timeouts. We have to set timer manually. |
Ok I managed to reproduce it again and haven't restarted it yet. Let me know what you want to see asap. :)
Yes. It is best to set up a profile that you can consistently connect to, in order to reproduce this bug.
Yes.
I also get logs like |
@Mygod Is the traffic stat still updating? |
Yes. |
Nope, I followed the same steps and everything works well. |
BTW, any special on your WiFi? For example, does it block all the external DNS servers or require web authentication? |
No it is a normal home WiFi. Doing this in reverse order does not seem to trigger the issue (i.e. if it starts with Wi-Fi network, then turning on/off data/Wi-Fi does not seem to cut off the connection at all). |
It looks a bug of the Android system on some specific devices. Let's wait for more reports if anyone else can reproduce this issue. |
I am using latest Android 11 on Pixel 3A XL though. 😅 I've tried switching |
Too lazy to debug further... Maybe another day. 🤣 |
I have no idea man. It seems to occur randomly.
Bypassed traffic still works properly. |
@zonyitoo Any thoughts? Only proxied streams are getting errno 101, bypassed streams are working fine. |
I think it might be an issue with server name being a domain name, i.e. some bugs in |
Err.. I remember that @madeye said shadowsocks-android starts DNS queries triggered by |
Ok you are right. |
On the other hand, once I change my server to IP, the issue seems to go away. 🤔 |
It depends. In the latest shadowsocks-android, the hostname is resolved to IP address in shadowsocks-android only if there's one plugin enabled: shadowsocks-android/core/src/main/java/com/github/shadowsocks/bg/ProxyInstance.kt Line 50 in 181ef53
So, it would be related to the local DNS resolver of shadowsocks-rust. BTW, even this is the root cause, I still cannot reproduce it following #2667 (comment) on my device. |
Wtf? |
I remember you fixed it before, it should be protected now? |
This comment has been minimized.
This comment has been minimized.
I just added a log in The patch: insert this at line 33 |
I saw this too but I am starting to think that this is not functional. See my previous comment. |
Does shadowsocks-android passed |
Yes. shadowsocks-android/core/src/main/java/com/github/shadowsocks/bg/ProxyInstance.kt Line 86 in 181ef53
|
Then it should work. Please check if there are any logs like: Or shadowsocks-android can double check if it receives any queries about remote servers' host. |
I know what 39f784a fixes. I don't know why it fixed this but it fixed this. |
Attempts at addressing shadowsocks#2667.
Attempts at addressing shadowsocks#2667.
* Allow user to keep data when uninstalling (shadowsocks#2506) * Update README.md * Update dependencies * Add cargo clean task * Enable LTO * Speed up rebuild * Update issue templates with labels * Update dependencies * Fix output name second attempt * Update NDK * Ensure cargoBuild is ran before mergeJniLibFolders * Bump version * Refine release build process * Refine gradle files * Add RUST_BACKTRACE * Use rethrowAsSocketException * Suppress write errors to protect_path * Update shadowsocks-rust * Bump version * Improve accessibility * Rename cipher plain to none * Revert "Add RUST_BACKTRACE" This reverts commit fdff88e. ndk-stack should be used instead. * Use cp.cloudflare.com for connectivity test Credits: https://www.v2ex.com/t/656983#r_8748918 * Update dependencies * Remote DNS setting is enabled unconditionally * Show more information on conflicting plugins Because one of you feckers just cannot learn to be decent. * Add support for PTR queries * Prevent querying PTR on custom Network * Suppress network unspecified exceptions * Handle IOException while reading * Refine handling duplicate plugins * Use any address as default DNS * Suppress EACCES for ProtectWorker * Clean up unused code * Do not suppress IOException * Disable UDP relay if plugin is enabled and no fallback * Remove unnecessary isExperimental * Update dependencies * Fix unchecked cast * Do not use WorkManager in device storage * Remove unnecessary directBootAware overloading * Suppress BadConfigurationProvider * Disable RemoveWorkManagerInitializer lint for apps * Update to Android 11 beta 1 * Request QUERY_ALL_PACKAGES for mobile * Refine code style * Fix ambiguous coroutineContext * Downgrade coroutines * Update dependencies * Deprecate using Handler * Fix shadowsocks#2546 * Only match exported plugins * Update dependencies * Update dependencies * Migrate to ML kit for scanning QR code Fixes shadowsocks#2548. * Make scanner immersive * Lock orientation to prevent camera recreation * Fix missing Serializable declaration * Add missing serialVersionUID * Update dependencies * Partially migrate to ActivityResultContracts AlertDialogFragment will be migrated after the API goes stable. * Add ActionBar to oss activity * Add ActionBar to details activity * Refine Scanner * Bump version * Update dependencies * Suppress cancellation exceptions * Skip processing if EOS is reached * Refine PTR compat * Fix shadowsocks#2557 * Fix shadowsocks#2562 * Update Android gradle * Set VPN flag properly Refine shadowsocks#2562. * Drop support for Android Lollipop * Update dependencies * Remove UDP upstream DNS support. Fix shadowsocks#2564 shadowsocks#2518 * Update shadowsocks-rust * Update dependencies * Decouple main dependencies from plugin lib * Simplify code * Add missing type * Update dependencies * Deprecate old backup mechanism for Android 5- * Update leanback theme to appcompat * Use singleTask launchMode * Fix build * Bump version * Update dependencies * Update dependencies * Bump plugin lib version to 2.0.0 * Add isV2 to PluginManager.InitResult * Pass a value with the VPN option, if plugin version < 2.0 * Switch to __android_vpn * Remove unnecessary parentheses * Update shadowsocks-rust * Bump version * Clean up and bump version * Revert camera-view back to alpha17 * Bump version * Update dependencies * Migrate away from deprecated APIs with core 1.3.0-alpha05 * Clean up code * Refine code style * Remove old ciphers. Fix shadowsocks#2621 * Enable single-threaded * Update shadowsocks-rust to 1.8.23 * Use Parcelize for TrafficStats * Fix platform insets on API 29- * Fix shadowsocks#2623 * Update barcode-scanning * Fix shadowsocks#2571 * Refine error message * Refine shadowsocks#2571 * Limit open sockets to 256 in UDP association. Fix shadowsocks#2625 * Bump version * Fix little problem of profile switching * Update shadowsocks-rust to 1.9.0 (shadowsocks#2622) * Fix shadowsocks#2638 * Bump version * Switch to local UDP DNS resolver (shadowsocks#2635) * Switch to the local UDP DNS resolver * Update shadowsocks-rust * Revert the rustup commands * Fix shadowsocks#2642 * Fix the ByteBuffer allocation * Update shadowsocks-rust * Revert to local UDS resolver Fix shadowsocks#2650 * Check deprecated ciphers (shadowsocks#2651) * Bump version * Fix shadowsocks#2301 * Bump version * Remove the non-ietf chacha20 and salsa20 ciphers * Fix shadowsocks#2665 * Update dependencies * Fix deprecation of kotlin extensions * Remove unused gcm work library for API 23+ * Use work-multiprocess * Refine code style * Update dependencies (shadowsocks#2672) * Update dependencies * Refine code style * Bump gradle to 6.8.2 * Drop packet if out of buffer * Refine error message * Enlarge the buffer size of a UDP connection * Bump version * Ignore all exceptions whilst updating subscriptions * Refine the JSON config file for ss-rust 1.10 * Refine the code style * Update shadowsocks-rust to v1.10.3 * Fix shadowsocks#2679 * Update dependencies Fixes shadowsocks#2699. * Fix deprecation of adapterPosition * Bump plugin to 2.0.1 * Migrate AlertDialogFragment to fragment result API * Remove useless dependency update * Migrate the rest to fragment result API * Remove unused field * Prevent crashing on shitty ROMs * Add search tool for profiles (shadowsocks#2682) * Suppress logging unsupported query type errors * Ignore if connection was prematurely closed * Use default udp_timeout=300 instead Refine shadowsocks#2625. * Mark underlyingNetwork as volatile Attempts at addressing shadowsocks#2667. * Fixed required targetFragments for preference * Downgrade gradle plugin * Update shadowsocks-rust and add back some ciphers Fix shadowsocks#2705 and shadowsocks#2663. * Update dependencies * Check plugin properly Fix shadowsocks#2667. * Check crypto before init * Make code style more Kotlin * Update core and remove workaround * Refine search to respect locale * Double fixes touch target * Resolve server name dynamically always (shadowsocks#2731) Fixes shadowsocks#2722. * Bump version * Downgrade fragment to 1.3.2 Fixes shadowsocks#2733. * Make plugin library depend on minimum version instead * Enable Parallel GC * Set useLegacyPackaging * Update the maven publish plugin (shadowsocks#2734) 1. Remove the unnecessary custom URL 2. Replace jcenter with mavenCentral * Handle illegal profiles properly * Fix windows build failed shadowsocks#2666 shadowsocks#2711 * Allowed build under msys2 or cygwin * Update dependencies * Bring back semitransparent TV app via build variants (shadowsocks#2741) This creates two variants for tv, freedom containing the original design, and google containing one matching Google's nonsense guideline. The former should be published on GitHub and elsewhere. Revert "Revert "Revert "Revert "Revert "Make app fullscreen to match guidelines""""" This reverts commit 0c67ac6. * Fix typo * Show full proxied apps mode to compensate for missing title * Use MaterialAlertDialogBuilder * Add progress indicator to ServiceButton * Remove elevation from progress * Only show progress for connecting * Only show progress when connecting is taking too long * Bump version * Update dependencies * Update sdk to S * Use registerBestMatchingNetworkCallback * Use OsConstants.ENONET * Deal with new requirements * Use main thread for default network callback on API 26+ * Remove unused code * Fix duplicate authentication * Update dependencies * Bump version * More stupid Android 6 bugs * Update dependencies * Downgrade leanback-preference * Update to API 31 * Remove STORAGE permission on Android 10+ * Update dnsjava * Ensure that redirects are always followed Fixes shadowsocks#2786, shadowsocks#2791. * Update dependencies * Update to AGP 7.0.2 * Fix lint * Update dependencies * Fix shadowsocks#2803 * Remove extra file * v5.2.6 * Revert "Show full proxied apps mode to compensate for missing title" This reverts commit d21cf7b. Fixes shadowsocks#2806. * Add linkedin.com to gfwlist * Fix Codacy badge * Update dependencies * Update .gitignore ignore DS_Store * Just to satisfy the obsessive-compulsive disorder :-) * Update shadowsocks-rust Update rust dependency * add new ciphers feature, and reorder cipher name * Modify acl rules * Update config.yml try to fix up the rust build error * enable armv8, neon feathures for hardware acceleration. * Fix the missing springAnimator * Update shadowsocks-rust to v1.15.0-alpha.5 * Bump version * Update translations Fixes shadowsocks#2867. * Add German and Ukrainian translations * Misc fixes * Fix order * Use system resolver * Update dependencies * Declare POST_NOTIFICATIONS * Protect sensitive profile information when copied * Add support for monochrome icons (not recommended) * Declare supported languages * Require authentication for closing service * Support skipping animation in StatsBar * Downgrade AGP * Misc fixes * Turn on fun switch * Remove useless code * Bump version * Fix the compile error shadowsocks#2930 (shadowsocks#2935) Make checking python version code compatible with windows and *nix Redefine the python version detection code Co-authored-by: Mygod <[email protected]> Co-authored-by: Mygod <[email protected]> Co-authored-by: Max Lv <[email protected]> Co-authored-by: cyber386 <[email protected]> Co-authored-by: Goooler <[email protected]> Co-authored-by: SquallATF <[email protected]> Co-authored-by: dev4u <[email protected]>
Describe the bug
Sometimes the Internet fails entirely when Shadowsocks keeps running for a while. This is a new bug introduced around v5.1.7 until latest master.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Shadowsocks should work 24/7.
Relevant logcat
This message is repeated 6 times over 4 seconds, around when the DNS goes down. Not sure if it is related though.
Smartphone (please complete the following information):
Configuration
Put an
x
inside the [ ] that applies.The text was updated successfully, but these errors were encountered: