Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libsubid.so shouldn't require symbol Prog #329

Closed
alexey-tikhonov opened this issue May 2, 2021 · 3 comments · Fixed by #348
Closed

libsubid.so shouldn't require symbol Prog #329

alexey-tikhonov opened this issue May 2, 2021 · 3 comments · Fixed by #348

Comments

@alexey-tikhonov
Copy link

$ grep Prog lib/prototypes.h 
extern /*@observer@*/ const char *Prog;

$ nm -D /usr/lib64/libsubid.so | grep Prog
                 U Prog

This is quite unexpected for applications linking with libsubid: .../lib64/libsubid.so: undefined reference to 'Prog'

@hallyn
Copy link
Member

hallyn commented May 4, 2021

Hm, yes, but that could be painful to undo as it's pretty deeply entrenched. Will need to think if there's a nice way to handle that.

@alexey-tikhonov
Copy link
Author

Probably libsubid could define this symbol locally (to some stub value like "shadow-utils:libsubid")?

@hallyn
Copy link
Member

hallyn commented May 4, 2021

I was also thinking of supporting some sort of subid_init("myprog") call (which later might support other configurations... but I doubt people would want to add such a call.

The (deeply entrenched) uses of Prog tend to be in the same places as use of stderr, so I think a generally logging infrastructure might be the best answer to both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants