Merge/vsdk 1.4.304 #6199

cheneym2 · 2025-01-28T16:25:34Z

Merge changes through be2accb5c6f86aa6f6e5502bada (v2025.3.2)

* Split out SPIR-V -specific legalization of global functions This is a refactoring and should not affect generated code. * Move global inst inlining code into separate function This is a refactoring and should not affect generated code. * Take SPIR-V -specific parts out of GlobalInstInliningContext This is a refactoring and should not affect generated code. * Move 'inlineGlobalValues' to generic inlining context This is a refactoring and should not affect generated code. * Move 'setInsertBeforeOutsideASM' to generic inlining context This is a refactoring and should not affect generated code. * Move generic inlining context into own file This is a refactoring and should not affect generated code. * Run global inlining for WGSL as well * Make the 'getOutsideASM' function generic as well * Enable language-feature/constants/static-const-in-generic-interface.slang for WebGPU * Clarify when it's safe to remove and deallocate an IRInst * Remove globals if they're left unused after inlining This closes shader-slang#5607. * Handle IRGlobalValueRef in C-like emitter * format code --------- Co-authored-by: slangbot <[email protected]>

* Add an example for using the reflection API The example program is meant to accompany a document that goes into more detail about the mental model behind the reflection API and the way this program drives it. Ideally this program can land before the document goes live, and then the document can be published with a link to the example. After that, the example could be updated to include links into the live document. Along with adding the example program, this change also adds some convenience functions to the reflection API to avoid cases where the program would otherwise need to cast between `slang::ParameterCategory` and `SlangParameterCategory`. * format code * fixup: error noticed by clang --------- Co-authored-by: slangbot <[email protected]>

This will necessetate changing the "required tests" setting on the GitHub repo Co-authored-by: Yong He <[email protected]>

* promoting bitfield extraction and insertion to become intrinsics for internal compiler use * removing duplicate intrinsics from glsl.meta.slang * refactor: update function signatures of bitfield extraction and insertion to use uint as the parameter type for offset and bits. --------- Co-authored-by: Nate Morrical <[email protected]> Co-authored-by: Yong He <[email protected]>

…der-slang#5855) * bump slang-rhi * More precise slang-rhi settings --------- Co-authored-by: Yong He <[email protected]>

* Update reflection API chapter in User guide The new version of the chapter is intended to accompany the `reflection-api` example program, and reflects (pun intended) the best practices that the Slang project team wants to encourage for interacting with the reflection API. * Rebuild TOCs

)

Closes shader-slang#5876

* Fix `getArgumentValueFloat` when arg is int. * format code --------- Co-authored-by: slangbot <[email protected]>

* Fix entrypoint auto discovery logic. * format code --------- Co-authored-by: slangbot <[email protected]>

Close shader-slang#5470 * implement bitcast for 64-bit date type * Move 'ensurePrelude' to base class to remove duplication * Assert on 'double' type for Metal target, as Metal doesn't have 'double' support

…shader-slang#5890)

…slang#5887) * Add verification logic on push and specialization constants. * format code --------- Co-authored-by: slangbot <[email protected]>

* Examples: Don't proceed if 'initializeBase' fails * Examples: Only access gWindow if it's been initialized * Examples: Free memory from CommandLineToArgvW * Add example run step to CI Lots of examples are still unexpectedly failing, but is one small step towards addressing issue shader-slang#5520.

…ut. (shader-slang#5889) * Allow `Optional` and `Tuple` to be used in varying input/output. * Fix. * format code * Fix. * Fix test. * Fix. * enhance test. * Fix. * format code --------- Co-authored-by: slangbot <[email protected]>

…lang#5907)

Close shader-slang#5911. In this issue, if we define the generic in source file 1, and import it into source file 2, then when parsing the reference of that generic in source file 2, we will not parse the generic directly, instead we have a logic to speculate it as generics first with a fake diagnostic sink, and if there is no error report, we will consider it as a actual generic and will parse it again. In this logic, we will also disambiguate the expression based on the following token, but we didn't consider the token '[', so we will finally not treat the expression as generic. The fix is just simply add '[' here. Co-authored-by: Yong He <[email protected]>

This helps to address issue shader-slang#5520.

* Fix issues reported by 'shellcheck' This helps to address issue shader-slang#5520. * format code --------- Co-authored-by: slangbot <[email protected]>

Co-authored-by: Yong He <[email protected]>

…izationLevel::Maximal (shader-slang#6137)

* Fix bug: IgnoreInheritance in lookup When specifying IgnoreInheritance in lookup, it will ignore all members in the self extension for generic, the reason is that it doesn't specialize the target type of the extension decl when comparing with self type, so it will result that every type is unequal to the target type.

…ng#6143) This closes shader-slang#5950.

…slang#6145) Pick up fix to shader-slang#5859

…r-slang#6131) * fix metal entry point global params * address review comments, cleanup and test * remove dead code * undo accidental change * address review comments and cleanup * minor fix and cleanup --------- Co-authored-by: Yong He <[email protected]>

* Use SPIRV integer vector dot product instructions * fix test --------- Co-authored-by: Yong He <[email protected]>

* Reimplement the GLSL atomic* functions in terms of __intrinsic_op Many of these functions map directly to atomic IR instructions. The functions taking atomic_uint are left as they are. This helps to address shader-slang#5989, since the destination pointer type validation can then be written only for the atomic IR instructions. * Add validation for atomic operations Diagnose an error if the destination of the atomic operation is not appropriate, where appropriate means it's either: - 'groupshared' - from a device buffer This closes shader-slang#5989. * Add tests for GLSL atomics destination validation Attempting to use the GLSL atomic functions on destinations that are neither groupshared nor from a device buffer should fail with the following error: error 41403: cannot perform atomic operation because destination is neither groupshared nor from a device buffer. * Validate atomic operations after address space specialization Address space specialization for SPIR-V is not done as part of `linkAndOptimizeIR`, as it is for e.g. Metal, so opt out and add a separate call for SPIR-V. * Allow unchecked in/inout parameters for non-SPIRV targets * Clean up callees left without uses during address space specialziation * format code --------- Co-authored-by: slangbot <[email protected]> Co-authored-by: Yong He <[email protected]>

* Cache and reuse glsl module. * Fix. * Implement record/replay for the new api. * Fix record replay. * Fix test.

* Fix incorrect resolve of specialization instance While checking the uninitialized variables, we were not resolving the specialized instance correctly. This commit repeats the resolve while the result is a specialization instance. A new test is added for this: tests/diagnostics/uninitialized-generic.slang After the problem is fixed, it revealed another problem in existing tests: tests/compute/nested-generics2.slang tests/diagnostics/uninitialized-local-variables.slang When a struct has a member variable whose type is a generic type, we cannot iterate over its member variables yet, because the type is unknown until the generic function/struct is specialized. We will have to give up checking for these cases.

* Add SLANG_ENABLE_RELEASE_LTO cmake option * Fix cmake static build * Disable install SlangTargets to avoid static build failing

Co-authored-by: Yong He <[email protected]>

* add brga8 format * add tests * minor fixes * cleanup * maybe fix broken quad control test * add missing xslang flag on test --------- Co-authored-by: Yong He <[email protected]>

…ang#6160) * Add intptr_t abs/min/max operations for CPU & CUDA targets * Define intptr_t and uintptr_t with CUDACC_RTC --------- Co-authored-by: Yong He <[email protected]>

* Sharpen the requirements for formatting * Add option to only format files changed since a given revision * Avoid divison-by-zero when total is zero * format code --------- Co-authored-by: slangbot <[email protected]>

* Fix an incorrect iteration with a workList We cannot modify workList while iterating it, because its type `List` is actually an array container. * Change based on the feedback * Use `Index` instead of `int` for for-loop index --------- Co-authored-by: Yong He <[email protected]>

CLAassistant · 2025-01-28T16:25:48Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
10 out of 11 committers have signed the CLA.

✅ saipraveenb25
✅ csyonghe
✅ fairywreath
✅ aleino-nv
✅ juliusikkala
✅ jkwak-work
✅ ramenguy99
✅ kaizhangNV
✅ spking11
✅ cheneym2
❌ KhronosWebservices
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

expipiplus1 and others added 30 commits December 12, 2024 10:27

Fix prebuilt dependencies filenames on non-windows platforms (shader-…

160be8e

…slang#5848)

Correct casing of windows includes (shader-slang#5849)

50fa543

Bump imgui for include fix (shader-slang#5854)

df06e79

Add missing header for _getpid() (shader-slang#5852)

96a8781

Set default hidden visibility for all source on gcc (shader-slang#5850)

7279c04

Correctly distinguish between windows and MSVC (shader-slang#5851)

48ac6f2

Partially sorts shader-slang#5843

Add SLANG_ENABLE_DXIL (shader-slang#5853)

79dc7ef

use Release over RelWithDebInfo for ci (shader-slang#5846)

b4e63d7

This will necessetate changing the "required tests" setting on the GitHub repo Co-authored-by: Yong He <[email protected]>

Make slang-rhi's NVAPI support conditional on SLANG_ENABLE_NVAPI (sha…

9d89a25

…der-slang#5855) * bump slang-rhi * More precise slang-rhi settings --------- Co-authored-by: Yong He <[email protected]>

Enable exprs for all supported GLSL layout qualifiers (shader-slang#5857

83f4bd5

)

install mono for toc generation (shader-slang#5877)

0a6ffee

Closes shader-slang#5876

Support matrix negation in metal backend. (shader-slang#5891)

9c9e1f7

Fix getArgumentValueFloat when arg is int. (shader-slang#5888)

d61bba8

* Fix `getArgumentValueFloat` when arg is int. * format code --------- Co-authored-by: slangbot <[email protected]>

Update 09-reflection.md (shader-slang#5886)

7ffc69d

Fix entrypoint auto discovery logic. (shader-slang#5885)

49e912a

* Fix entrypoint auto discovery logic. * format code --------- Co-authored-by: slangbot <[email protected]>

Implement bitcast for 64-bit date type (shader-slang#5895)

6f57e47

Close shader-slang#5470 * implement bitcast for 64-bit date type * Move 'ensurePrelude' to base class to remove duplication * Assert on 'double' type for Metal target, as Metal doesn't have 'double' support

Support specializing generic entrypoints in findAndCheckEntryPoint. (…

6e24244

…shader-slang#5890)

Add verification logic on push and specialization constants. (shader-…

45af246

…slang#5887) * Add verification logic on push and specialization constants. * format code --------- Co-authored-by: slangbot <[email protected]>

Fix metadata of register space and varying params. (shader-slang#5906)

0f5a2ce

Support explicit [vk::location(n)] binding on metal/wgsl. (shader-s…

abeb375

…lang#5907)

Check decl nesting for namespaces. (shader-slang#5910)

a805756

Refresh list of failing examples (shader-slang#5904)

58654d0

This helps to address issue shader-slang#5520.

Fix issues reported by 'shellcheck' (shader-slang#5913)

a427c58

* Fix issues reported by 'shellcheck' This helps to address issue shader-slang#5520. * format code --------- Co-authored-by: slangbot <[email protected]>

fairywreath and others added 22 commits January 17, 2025 23:07

Implement Quad Control intrinsics (shader-slang#5981)

a85c350

Make -depfile work for binary modules output too (shader-slang#6126)

d09b6bc

Fix upper 32 bits of 64-bit AnyValue packing (shader-slang#6127)

f3d7aa6

Fix def-use issue from multi-level break elimination (shader-slang#6134)

b11c257

Generate IDs for every witness table (shader-slang#6129)

6812245

Co-authored-by: Yong He <[email protected]>

Fix gcc downstream compiler optimization level corresponding to Optim…

4c2c085

…izationLevel::Maximal (shader-slang#6137)

Catch all exceptions from loadModule* and link API calls. (shader-sla…

a4d67a0

…ng#6143) This closes shader-slang#5950.

Bump spirv-tools to 9295a8b94ed0751565fa9cda6d949f5e388b32d9 (shader-…

ea98e24

…slang#6145) Pick up fix to shader-slang#5859

Use SPIRV integer vector dot product instructions (shader-slang#6141)

18f12ad

* Use SPIRV integer vector dot product instructions * fix test --------- Co-authored-by: Yong He <[email protected]>

Cache and reuse glsl module. (shader-slang#6152)

8000e0e

* Cache and reuse glsl module. * Fix. * Implement record/replay for the new api. * Fix record replay. * Fix test.

Fix static build and install (shader-slang#6158)

ac174d2

* Add SLANG_ENABLE_RELEASE_LTO cmake option * Fix cmake static build * Disable install SlangTargets to avoid static build failing

improve error message on generic value decls (shader-slang#6169)

92c9fff

Co-authored-by: Yong He <[email protected]>

Add bgra8 format (shader-slang#6163)

0dd9076

* add brga8 format * add tests * minor fixes * cleanup * maybe fix broken quad control test * add missing xslang flag on test --------- Co-authored-by: Yong He <[email protected]>

Add intptr_t abs/min/max operations for CPU & CUDA targets (shader-sl…

1abba25

…ang#6160) * Add intptr_t abs/min/max operations for CPU & CUDA targets * Define intptr_t and uintptr_t with CUDACC_RTC --------- Co-authored-by: Yong He <[email protected]>

Fix depth texture sampling on Metal. (shader-slang#6168)

3ecbeac

DNI: try using sparse checkout for MDL-SDK (shader-slang#6190)

1f1892d

cheneym2 requested review from tangent-vector, csyonghe, expipiplus1 and a team as code owners January 28, 2025 16:25

csyonghe approved these changes Jan 28, 2025

View reviewed changes

cheneym2 added the pr: breaking change PRs with breaking changes label Jan 28, 2025

cheneym2 merged commit 839bc9a into shader-slang:vulkan-sdk-1.4.304 Jan 28, 2025
48 of 50 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge/vsdk 1.4.304 #6199

Merge/vsdk 1.4.304 #6199

cheneym2 commented Jan 28, 2025

CLAassistant commented Jan 28, 2025 •

edited

Loading

Merge/vsdk 1.4.304 #6199

Merge/vsdk 1.4.304 #6199

Conversation

cheneym2 commented Jan 28, 2025

CLAassistant commented Jan 28, 2025 • edited Loading

CLAassistant commented Jan 28, 2025 •

edited

Loading