Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add design doc for write-only textures. #5455

Merged
merged 3 commits into from
Oct 30, 2024

Conversation

csyonghe
Copy link
Collaborator

No description provided.

@csyonghe csyonghe added the pr: non-breaking PRs without breaking changes label Oct 30, 2024
jkwak-work
jkwak-work previously approved these changes Oct 30, 2024
Copy link
Collaborator

@jkwak-work jkwak-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
But it wasn't clear to me how "write-only" can solve the problem "read-write" has until I check the table that Kai referred to.
https://www.w3.org/TR/webgpu/#texture-format-caps
It appears that "write-only" and "read-only" supports more texel types compared to "read-write".

Copy link
Contributor

@tangent-vector tangent-vector left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only question I have is why there's this prefix of kCoreModule_* on the resource access enum values.

@csyonghe
Copy link
Collaborator Author

The entire _Texture type and argument values to pass to the generic parameters are all internal now, and the enum in this case doesn't really have a presence in the actual slang module yet. They are all referenced through backquotes as in $(kCoreModule_ResourceAccessReadOnly), so this should be considered as implementation detail.

@csyonghe csyonghe merged commit feec3cf into shader-slang:master Oct 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: non-breaking PRs without breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants