Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update slang-rhi with initial wgpu support #5137

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

skallweitNV
Copy link
Collaborator

@skallweitNV skallweitNV commented Sep 23, 2024

  • Add initial support for WebGPU using Google Dawn.

@skallweitNV skallweitNV added the pr: non-breaking PRs without breaking changes label Sep 23, 2024
@skallweitNV
Copy link
Collaborator Author

skallweitNV commented Sep 23, 2024

any idea why sccache is failing on slang-rhi files? is this just a fluke?

FAILED: external/slang-rhi/CMakeFiles/slang-rhi.dir/Release/src/vulkan/vk-module.cpp.o 
sccache /Applications/Xcode_15.4.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++ -DSLANG_RHI_ENABLE_CPU=1 -DSLANG_RHI_ENABLE_CUDA=0 -DSLANG_RHI_ENABLE_D3D11=0 -DSLANG_RHI_ENABLE_D3D12=0 -DSLANG_RHI_ENABLE_METAL=1 -DSLANG_RHI_ENABLE_VULKAN=1 -DSLANG_RHI_ENABLE_WGPU=1 -DCMAKE_INTDIR=\"Release\" -I/Users/runner/work/slang/slang/include -I/Users/runner/work/slang/slang/external/slang-rhi/include -I/Users/runner/work/slang/slang/external/slang-rhi/src -I/Users/runner/work/slang/slang/external/slang-rhi/external/vulkan-headers/include -I/Users/runner/work/slang/slang/external/slang-rhi/external/metal-cpp -isystem /Users/runner/work/slang/slang/build/_deps/dawn-src/include -Wno-assume -Wno-switch -O3 -DNDEBUG -std=gnu++17 -arch arm64 -isysroot /Applications/Xcode_15.4.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.5.sdk -fPIC -w -Werror -MD -MT external/slang-rhi/CMakeFiles/slang-rhi.dir/Release/src/vulkan/vk-module.cpp.o -MF external/slang-rhi/CMakeFiles/slang-rhi.dir/Release/src/vulkan/vk-module.cpp.o.d -o external/slang-rhi/CMakeFiles/slang-rhi.dir/Release/src/vulkan/vk-module.cpp.o -c /Users/runner/work/slang/slang/external/slang-rhi/src/vulkan/vk-module.cpp
sccache: encountered fatal error

@csyonghe csyonghe merged commit 14b1098 into shader-slang:master Sep 23, 2024
11 of 12 checks passed
@jkwak-work
Copy link
Collaborator

sccache issue is resolved after I delete the cache.
The cache probably went wrong or corrupted.

But I noticed that Linux Release is failing for real.

/usr/lib/gcc-cross/aarch64-linux-gnu/9/../../../../aarch64-linux-gnu/bin/ld: _deps/dawn-src/lib64/libdawn.so: error adding symbols: file in wrong format

@csyonghe
Copy link
Collaborator

It is probably trying to use x86 build for aarch64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: non-breaking PRs without breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants