Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-note.sh fixes #5068

Merged
merged 3 commits into from
Sep 17, 2024

Conversation

cheneym2
Copy link
Collaborator

Add a gh.exe search path that works with cygwin installations.

Do not bail out from the breaking changes loop when a change is found without PR#. Instead, continue to the next one. This fixes an issue where [BREAKING] changes appear in the detailed change list by not in the summary of breaking changes.

Add a gh.exe search path that works with cygwin installations.

Do not bail out from the breaking changes loop when a change is
found without PR#. Instead, continue to the next one. This fixes
an issue where [BREAKING] changes appear in the detailed change
list by not in the summary of breaking changes.
@cheneym2 cheneym2 added the pr: non-breaking PRs without breaking changes label Sep 16, 2024
Copy link
Collaborator

@jkwak-work jkwak-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the bug.

@csyonghe csyonghe merged commit 25d1559 into shader-slang:master Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: non-breaking PRs without breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants