Remove Invalid from the supported profile names in help
#4822
+24
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes a keyword "Invalid" from the command-line help message. It also prints the profile names in an alphabetrically sorted order for a better searchability.
jkwak-work
force-pushed
the
fix/remove_Invalid_from_help_page_of_capability
branch
from
ac4889c
to
0bc42b6
Compare
ArielG-NV
approved these changes
Aug 12, 2024
This task has a plan to be handled with issue #4125 |
csyonghe
approved these changes
Aug 13, 2024
csyonghe
reviewed
Aug 13, 2024
| return (lhsLength < rhsLength); | ||
| } | ||
| }; | ||
| names.sort(CompareUnownedStringSlice()); |
There was a problem hiding this comment.
why can't this be a lambda?
csyonghe
reviewed
Aug 14, 2024
| { | ||
| Count lhsLength = lhs.getLength(); | ||
| Count rhsLength = rhs.getLength(); | ||
| Count minLength = std::min(lhsLength, rhsLength); |
|
I will address Yong's comment on Monday. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes a keyword "Invalid" from the command-line help message.
It also prints the profile names in an alphabetrically sorted order for a better searchability.
The list of profile names is still too verbose and not user-friendly but that will need to be addressed later.