Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): correct label in card demo #799

Merged
merged 2 commits into from
Jul 12, 2023
Merged

fix(docs): correct label in card demo #799

merged 2 commits into from
Jul 12, 2023

Conversation

0ui
Copy link
Contributor

@0ui 0ui commented Jul 1, 2023

I ran into a mislabeled input on this page when trying out shadcn/ui. If you click on the Framework label it selects the Name input instead. This PR:

  1. Corrects the label for framework
  2. Moves the <SelectContent /> outside of the <SelectTrigger /> to match the Select usage docs

@vercel
Copy link

vercel bot commented Jul 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 12, 2023 4:22pm
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 12, 2023 4:22pm

@vercel
Copy link

vercel bot commented Jul 1, 2023

@0ui is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@dan5py dan5py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@shadcn shadcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@shadcn shadcn merged commit f461ab0 into shadcn-ui:main Jul 12, 2023
suleymanbariseser pushed a commit to suleymanbariseser/shadcn-ui that referenced this pull request Jul 25, 2023
lloydrichards pushed a commit to lloydrichards/shadcn-ui that referenced this pull request Oct 3, 2023
kjxbyz pushed a commit to muse-ui/muse-ui that referenced this pull request Jun 7, 2024
artabr pushed a commit to artabr/shadcn-ui that referenced this pull request Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants