-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modularize lucide-react imports #464
Conversation
@ap-1 is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is handy. Thank you.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
@ap-1 This is failing with the following error:
|
The issue seems to occur when an alias for the icon is used instead of the original file. For example: /* apps/www/components/mobile-nav.tsx */
import { SidebarOpen } from "lucide-react" // errors
import { PanelLeftOpen as SidebarOpen } from "lucide-react" // works fine /* node_modules/lucide-react/dist/lucide-react.d.ts */
// PanelLeftOpen aliases
export declare const PanelLeftOpenIcon: LucideIcon;
export declare const LucidePanelLeftOpen: LucideIcon;
export declare const SidebarOpen: LucideIcon; I'm not quite sure how to work around this in
|
@ap-1 Thanks for the fix. This is now supported out of the box in Next.js. See vercel/next.js#53051 (Closing this as completed. Feel free to reopen if not). |
Closes #267