Make Shaarli's template W3C compliant #64

[ArthurHoaro]

#64

Every page should pass W3C validator. Further tests should be done, but that's a good start. Thanks to @virtualtam.

[ArthurHoaro]

to see it, you may need a shaarli w/ enough links to display those links

True, I only tried it with an almost empty Shaarli.

could you briefly describe in the commit message which styling/conformity points are being fixed?

Which commit message?

Anyway,

Home page
& is not escaped in QRcode links (redundant with #57?);

Don't know about #57, but links should be valid.

the name attribute is obsolete for links;

Only ID is necessary.

paging IDs are duplicated (top and bottom), classes should be used instead;

Ok, but needs work for the last IDs.

specifying Javascript as the script language is deprecated.

Ok.

Tag cloud, Picture wall
center is deprecated.

Ok, replace with text-align: center CSS class.

Picture wall
the template declares div class="picwall_container", which should be an ID (which is the case in the CSS).

Ok.

Daily
& is not escaped in previous/next day links;

Ok.

the code used for the dashes surrounding the daily date is invalid and should be replaced by —,

Ok.

[virtualtam]

could you briefly describe in the commit message which styling/conformity points are being fixed?

Which commit message?

As the size of the PR is quite small, there should only be one commit; during the review process, when taking feedback into account, you may either:

• amend and re-(force-)push it on your w3c dev branch, which will update the PR;
• for more consequent patches, issue a series of commits that can be squashed when the PR is ready for merge.

[ArthurHoaro]

Alright, thanks for the help and the review. I'll do that when we decide the PR is ready to fly.

[nodiscc]

Hi @ArthurHoaro thanks for working on this. I'll be glad to merge your changes if each commit message details what points from #64 are fixed in it. You are not forced to fix the W3C compliance in ONE PR. For example a PR with only this would be welcome;

W3C compliance: fix duplicate IDs
  * #paging_older, #paging_newer become classes as the paging is displayed twice (top, bottom) in the linklist
  * work on https://github.com/shaarli/Shaarli/issues/64

Let me know if you need help with git commands needed to do this (you may need to split your commits using git rebase -i)

[ArthurHoaro]

Let me know if that's good enough.

EDIT: Forced push removed @virtualtam commit comments.

[nodiscc]

Everything ok, thanks for the patch!

There are some missing explanations in the commit message (see above), can you add them? (and there is a duplicate line in the message). Just a git commit --amend on the w3c branch really. Otherwise I could do it when I get some time.

git remote add arthurhoaro https://github.com/ArthurHoaro/Shaarli/
git remote update; git checkout w3c; git commit --amend; #edit message here
git checkout master; git merge w3c

[ArthurHoaro]

• Edit: I get it now. please add Fix missing alt attributes for img elements to the commit message.
• Please add to the commit message: tpl/daily: Use HTML entities instead of char escape codes
• Was the closing missing?
  If so please add tpl/export: fix missing closing tag to the commit message
• Please add Remove obsolete language attribute on <script> elements to the commit message

It's done.

[nodiscc]

merci bien

[nodiscc]

Continuing on #64