-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: bulk creation of bookmarks #1587
Feature: bulk creation of bookmarks #1587
Conversation
Good catch! Thanks for the report, I'll try to fix that tomorrow. |
fa862e1
to
c4366d4
Compare
c4366d4
to
e139d8b
Compare
Salut Arthur :) Nice feature, but maybe it would need some UI feedback when dealing with |
ec56693
to
b22116e
Compare
Merci Nico ! =) You are right, it's very obvious with a large batch of URLs like shown on your screencast. Note that while it works, my web server (or the social media where we extract metadata) doesn't very much like being hit by 60x2 HTTP requests from the same client a few seconds apart, and I have encountered a time out once. For large batches I'd recommend using our Python client + REST API, or the import/export format. |
This changes creates a new form in addlink page allowing to create multiple bookmarks at once more easily. It focuses on re-using as much existing code and template component as possible. These changes includes: - a new form in addlink (hidden behind a button by default), containing a text area for URL, and tags/private status to apply to created links - this form displays a new template called editlink.batch, itself including editlink template multiple times - User interation in this new templates are handle by a new JS script (shaare-batch.js) making AJAX requests, and therefore does not need page reloading - ManageShaareController has been split into 3 distinct controllers: + ShaareAdd: displays addlink template + ShaareManage: various operation applied on existing shaares (change visibility, pin, deletion, etc.) + ShaarePublish: handles creation/edit forms and saving Shaare's form - Updated translations Fixes shaarli#137
Reduced additional processing time per links from ~40ms to ~5ms
5c6d51b
to
34c8f55
Compare
This changes creates a new form in addlink page allowing to create
multiple bookmarks at once more easily. It focuses on re-using as much
existing code and template component as possible.
These changes includes:
containing a text area for URL, and tags/private status to apply to
created links
including editlink template multiple times
(shaare-batch.js) making AJAX requests, and therefore does not need page
reloading
(change visibility, pin, deletion, etc.)
form
Fixes #137
The PR is currently in progress because it relies on async retrieval of metadata (#1567 and #1584), but I encourage you to test it and provide any feedback you'd have, especially regarding the UI/UX.
You can find a live demo here: https://shaarli-batch.hoa.ro (demo/demo)