Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

German language created #1114

Merged
merged 5 commits into from
Apr 15, 2018
Merged

German language created #1114

merged 5 commits into from
Apr 15, 2018

Conversation

dbx-one
Copy link
Member

@dbx-one dbx-one commented Mar 31, 2018

All lines were translated to german, except one i could not find in the po file.

For each link, add a Wallabag icon to save it in your instance.

A bit of fine tuning is certainly still needed. Change requests are welcome. In my opinion according to the current status, it can be published.

@ArthurHoaro
Copy link
Member

That's great! Thank you!

I don't know what happened with that line, it should have been generated from the plugin administration page, just like for the other plugins... Did you use the generate_templates script?

How do we want to process for future new translation strings:

  • Do we just wait for eventual language update PR once in a while?
  • Do you want to be the maintainer of German translation, and be notified of new translations?

Copy link
Member

@virtualtam virtualtam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really nice @buster-one :)

msgstr ""
"Ziehe diese Link in deine Lesezeichen-Symbolleiste oder klicke mit der "
"rechten Maustaste darauf und wähle \"Speichere diesen Link als Lesezeichen\""

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lines 1314 through 1408 can be removed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed as suggested

"Report-Msgid-Bugs-To: \n"
"POT-Creation-Date: 2018-03-31 09:09+0200\n"
"PO-Revision-Date: 2018-03-31 09:12+0200\n"
"Last-Translator: \n"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel free to add your contact information here :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine. Others also contribute to it.

msgid "The tag was renamed in %d link."
msgid_plural "The tag was renamed in %d links."
msgstr[0] "Der Tage wurde im Link %d umbenannt."
msgstr[1] "Der Tage wurde in den Links %d umbenannt."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra space between den and Links

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was corrected as suggested

@virtualtam
Copy link
Member

@ArthurHoaro we could create a Translation team on Github and/or setup Transifex to encourage contributions, see related comments:

@nodiscc
Copy link
Member

nodiscc commented Mar 31, 2018

I second Transifex. I help maintaining https://www.transifex.com/youtube-dl-gui/youtube-dl-gui/ and so far it has been very successful, and pleasing to work with.

@dbx-one
Copy link
Member Author

dbx-one commented Mar 31, 2018

Did you use the generate_templates script?

Yeah several times. The script runs well but the line has not been generated.

Do you want to be the maintainer of German translation, and be notified of new translations?

Yes a very good idea. It would be e pleasure to support this project in this way.

Can not say anything about Transifex yet, but Poedit worked very well.

@virtualtam
Copy link
Member

@shaarli/translators team created! @buster-one, I've sent you an invitation so you can join it :)

Copy link
Member

@virtualtam virtualtam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See PR comments

@dbx-one
Copy link
Member Author

dbx-one commented Apr 15, 2018

@virtualtam Invitation accepted. :)

Copy link
Member Author

@dbx-one dbx-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made the changes. I hope this is the correct review process.

@virtualtam virtualtam merged commit 7ca1240 into shaarli:master Apr 15, 2018
@virtualtam
Copy link
Member

Thanks, merged! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants