Load theme translations files automatically #1093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virtualtam
reviewed
Mar 19, 2018
| "Plural-Forms: nplurals=2; plural=(n > 1);\n" | ||
| "X-Generator: Poedit 2.0.6\n" | ||
|
|
||
| msgid "cock" |
There was a problem hiding this comment.
this test should use reference data that is not likely to be interpreted as being suggestive :)
There was a problem hiding this comment.
WHAT'S WRONG WITH OUR PROUD NATIONAL SYMBOL?!
:origin()/pre00/c8fb/th/pre/f/2016/070/f/9/2016_03_deadpoule_by_decretaire-d9uovkx.jpg "Deadpoule")
application/Languages.php
Outdated
| $themeTransFolder = rtrim($this->conf->get('raintpl_tpl'), '/') .'/'. $theme .'/language'; | ||
| if (is_dir($themeTransFolder)) { | ||
| try { | ||
| /** @var Translations $translations */ |
There was a problem hiding this comment.
There was a problem hiding this comment.
I use this for type hinting in the IDE but the lib should handle it.
ArthurHoaro
force-pushed
the
feature/theme-translation
branch
3 times, most recently
from
62e2425 to
54ad016
Compare
Fixes shaarli#1077 Take a look at the docs update to see how it works
ArthurHoaro
force-pushed
the
feature/theme-translation
branch
from
54ad016 to
68c6afc
Compare
|
Rebased. |
virtualtam
approved these changes
Mar 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1077
Take a look at the docs update to see how it works