Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only allow links access via permalinks #475

Closed
qwertygc opened this issue Feb 14, 2016 · 15 comments · Fixed by #1597
Closed

Only allow links access via permalinks #475

qwertygc opened this issue Feb 14, 2016 · 15 comments · Fixed by #1597
Labels
Milestone

Comments

@qwertygc
Copy link

Hello ! J'aime bien le concept, et je voulais savoir si, quand on est pas connecté, il n'y pas la liste des liens, (il faut être abonné au RSS pour voir les articles ou avoir le permalien).

Si ça peut se faire sous forme de plugin... ?

@mro
Copy link

mro commented Feb 14, 2016

Hä?

@ArthurHoaro
Copy link
Member

He's talking about a 'no homepage' option, for privacy matters. So no multiple link list if you're logged out.

@mro
Copy link

mro commented Feb 15, 2016

thx.

@alexisju
Copy link

I guess it should be possible, but i think it will be easier to use a custom template than a plugin for that.

@nodiscc
Copy link
Member

nodiscc commented Feb 15, 2016

I see this as an addition to "Hide public links".

  • All links are hidden
  • There is a RSS feed whose URL is generated randomly and bypasses "hide public links".
  • Accessing a permalink bypasses "hide public link"

@alexisju
Copy link

n.survol.fr (the website given in link by @qwertygc) is just a wordpress website "without" frontpage, but all articles are published and online.

About Shaarli the same way is more like a specific template than a new core feature.

Hovewer, as @nodiscc suggest, when the shaarli is private it could be interesting to be able to generate a private rss link too.

@ArthurHoaro
Copy link
Member

I agree with @alexisju. A "featureless" template is a good way to make Shaarli only able to display permalinks.

Also, I'm more in favor of adding a 'share' URL to give access to a private link, or any link to make it work with HIDE_PUBLIC_LINKS. But it's going to be more difficult to do since we don't load private links for logged out users.

@nodiscc nodiscc changed the title Une page semi privée ? Only allow links access via permalinks Feb 15, 2016
@qwertygc
Copy link
Author

I have test the condition in linklist.html, but is hide, also if we search. I search just to hide for listing the links, not in search or tag

OK, in linklist.html,
l 66 : {if="isLoggedIn() || isset($_GET['searchterm']) || isset($_GET['searchtags'])"}

l116 {/if}

@qwertygc
Copy link
Author

I have create a pull request.

@ArthurHoaro
Copy link
Member

What's the point of hiding shaares in linklist if you can see them through the search, tags, daily, etc?

@qwertygc
Copy link
Author

L'idée c'est juste rendre plus opacte le shaarli, comme décrit dans l'article.

@ArthurHoaro
Copy link
Member

Opaque? Hmm... The blog post author writes something like this:

Yes, everything is accessible for anyone who would care to. Posts are browsable through pagination, RSS feed, or a search engine.

I'm talking about opacity because it's not closed, only harder to access. It protects me against quick "who am I" search.

I'm sorry but it feels like a pointless hack to me. I'd rather hide everything and eventually make permalink accessible (like etherpad for example), or show everything that's public.

@nodiscc
Copy link
Member

nodiscc commented Feb 16, 2016

Agreed, if ever this gets implemented it needs to only allow access to RSS/permalinks and not allow listing of links; otherwise there is no point to it - just hide the default page.

@qwertygc what you describe can easily be done with a simple .htaccess or server access restrictions/configuration (throw a 403, 404 or a custom page for URLs like ^shaarli/\? ^shaarli/\?page=.*$, eg see rewriterules. I suggest closing #478.

@ArthurHoaro ArthurHoaro modified the milestone: 0.7.0 Feb 18, 2016
@qwertygc
Copy link
Author

Si je comprends, on le met pas ?

@alexisju
Copy link

Perso, je ne pense pas non plus qu'il faille que ce soit intégré par défaut ; ça sort un peu de l'essence même de Shaarli. Par contre, n'hésite pas à développer ton template et le partager (en ajoutant un lien dans le wiki).

@ArthurHoaro ArthurHoaro modified the milestones: 0.9.0, 0.8.1 Oct 22, 2016
@ArthurHoaro ArthurHoaro modified the milestones: 0.9.0, 0.9.1 Jan 25, 2017
@virtualtam virtualtam modified the milestones: 0.10.0, 0.9.1 Jul 29, 2017
@virtualtam virtualtam modified the milestones: 0.10.0, 0.10.2 Jan 10, 2018
@ArthurHoaro ArthurHoaro modified the milestones: 0.10.2, 0.10.3 Jul 29, 2018
@ArthurHoaro ArthurHoaro modified the milestones: 0.10.3, 0.10.4 Aug 11, 2018
@virtualtam virtualtam modified the milestones: 0.10.4, 0.11.0 Feb 23, 2019
@ArthurHoaro ArthurHoaro modified the milestones: 0.11.0, 0.11.1 Jul 27, 2019
@ArthurHoaro ArthurHoaro modified the milestones: 0.11.1, 0.11.2 Aug 7, 2019
@ArthurHoaro ArthurHoaro modified the milestones: 0.12.0, 0.12.1 Sep 3, 2020
ArthurHoaro added a commit to ArthurHoaro/Shaarli that referenced this issue Oct 16, 2020
  - Add a share link next to « Permalink » in linklist (using share icon
from fork awesome)
  - This link generates a private key associated to the bookmark
  - Accessing the bookmark while logged out with the proper key will
display it

Fixes shaarli#475
ArthurHoaro added a commit to ArthurHoaro/Shaarli that referenced this issue Oct 16, 2020
  - Add a share link next to « Permalink » in linklist (using share icon
from fork awesome)
  - This link generates a private key associated to the bookmark
  - Accessing the bookmark while logged out with the proper key will
display it

Fixes shaarli#475
ArthurHoaro added a commit to ArthurHoaro/Shaarli that referenced this issue Oct 16, 2020
  - Add a share link next to « Permalink » in linklist (using share icon
from fork awesome)
  - This link generates a private key associated to the bookmark
  - Accessing the bookmark while logged out with the proper key will
display it

Fixes shaarli#475
ArthurHoaro added a commit to ArthurHoaro/Shaarli that referenced this issue Oct 20, 2020
  - Add a share link next to « Permalink » in linklist (using share icon
from fork awesome)
  - This link generates a private key associated to the bookmark
  - Accessing the bookmark while logged out with the proper key will
display it

Fixes shaarli#475
ArthurHoaro added a commit to ArthurHoaro/Shaarli that referenced this issue Oct 27, 2020
  - Add a share link next to « Permalink » in linklist (using share icon
from fork awesome)
  - This link generates a private key associated to the bookmark
  - Accessing the bookmark while logged out with the proper key will
display it

Fixes shaarli#475
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants