Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applying change tested by jasoncodes (#180) #183

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Applying change tested by jasoncodes (#180) #183

merged 2 commits into from
Apr 16, 2024

Conversation

sh00t2kill
Copy link
Owner

  • Applying change tested by jasoncodes

  • Removed new lines at the end of README


* Applying change tested by jasoncodes

* Removed new lines at the end of README

---------

Co-authored-by: Dan Wheaton <[email protected]>
@sh00t2kill sh00t2kill requested a review from elad-bar April 2, 2024 02:48
Copy link
Collaborator

@elad-bar elad-bar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changing the code should be done in a branch then PR to developer then to main,
code is ok

Copy link
Collaborator

@elad-bar elad-bar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls add manifest version update to 11 and readme documentation

@sh00t2kill
Copy link
Owner Author

"changing the code should be done in a branch then PR to developer then to main,"

This is what happened. This is the PR to main. Theres probably not a whole lot of point releasing this at the moment anyway with all the async issues that need to be fixed.

I havent had the time to look unfortunately.

@elad-bar
Copy link
Collaborator

Sorry, missed it, can you pls just update version in manifest and changelog?

Thanks

@elad-bar elad-bar merged commit 78eb10a into main Apr 16, 2024
1 check passed
@elad-bar
Copy link
Collaborator

@sh00t2kill merged, if you have time pls release new version, in case you don't i will release it later today

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants