Skip to content

Commit

Permalink
Corefile: Drop deprecated kubernetes upstream option
Browse files Browse the repository at this point in the history
coredns/coredns#3737 removed the unused
`upstream` kubernetes plugin option from the CoreDNS corefile parser.
Starting in CoreDNS v1.7, corefiles that have the `upstream` option will
throw an error. This change should not affect functionality since the
`upstream` option has been ignored since CoreDNS v1.5. The
aforementioned upstream CoreDNS PR merely requires that the
`upstream` option be removed for the kubernetes plugin section of a
corefile.
  • Loading branch information
sgreene570 committed Feb 24, 2021
1 parent cd9190c commit 742481c
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
1 change: 0 additions & 1 deletion pkg/operator/controller/controller_dns_configmap.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ var corefileTemplate = template.Must(template.New("Corefile").Parse(`{{range .Se
health
kubernetes {{.ClusterDomain}} in-addr.arpa ip6.arpa {
pods insecure
upstream
fallthrough in-addr.arpa ip6.arpa
}
prometheus 127.0.0.1:9153
Expand Down
1 change: 0 additions & 1 deletion pkg/operator/controller/controller_dns_configmap_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ bar.com:5353 example.com:5353 {
health
kubernetes cluster.local in-addr.arpa ip6.arpa {
pods insecure
upstream
fallthrough in-addr.arpa ip6.arpa
}
prometheus 127.0.0.1:9153
Expand Down

0 comments on commit 742481c

Please sign in to comment.