Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DataFrames v0.19 deprecations #17

Merged
merged 2 commits into from
Sep 10, 2019
Merged

Conversation

alyst
Copy link
Contributor

@alyst alyst commented Sep 9, 2019

Switches from haskey(df, colname) to hasproperty(df, colname) and from df[colname] to df[!, colname].
I guess that requires DataFrames v0.19 (or a bit earlier), but since it's an optional dependency, the check has yet to be coded in __init__(), which I can try to implement if needed.

@sglyon
Copy link
Owner

sglyon commented Sep 9, 2019

Hey thanks!

This is great.

Would you please note in the project.toml file that these changes require DataFrames version >= 0.19?

@alyst
Copy link
Contributor Author

alyst commented Sep 9, 2019

I've updated Project.toml, but, as I mentioned before, I'm not sure it's gonna work (in the ]test PlotlyBase I don't see that DataFrames.jl is used/or its version checked).
See also JuliaPackaging/Requires.jl#3.

@sglyon
Copy link
Owner

sglyon commented Sep 10, 2019

Thanks!

@sglyon
Copy link
Owner

sglyon commented Sep 10, 2019

oh shoot, you are right . Let's go back to the first commit.

My mistake! Sorry about that

@alyst
Copy link
Contributor Author

alyst commented Sep 10, 2019

No problem. Actually, maybe it's nice to keep these changes to Project.toml just as a future note?
So far they look dormant and should not negatively affect versions resolution.
Unfortunately, we cannot add clarifying comments to Project.toml as Pkg will strip them.

@sglyon sglyon merged commit e212bd8 into sglyon:master Sep 10, 2019
@alyst alyst deleted the fix_dataframe_api branch September 13, 2019 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants