Increase selenium for java11 (#1)

Increased Selenium to 3.14.0 to get bytebuddy 1.18.5 and Java 11 support. Fixed some failing tests.
sglahn · Oct 16, 2018 · 5787a38 · 5787a38
1 parent 91ba031
commit 5787a38
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 3 deletions.
diff --git a/galen-core/pom.xml b/galen-core/pom.xml
@@ -46,6 +46,11 @@
       <groupId>commons-io</groupId>
       <artifactId>commons-io</artifactId>
     </dependency>
+    <dependency>
+      <groupId>com.google.code.gson</groupId>
+      <artifactId>gson</artifactId>
+      <version>2.8.5</version>
+    </dependency>
     <dependency>
       <groupId>org.seleniumhq.selenium</groupId>
       <artifactId>selenium-java</artifactId>

diff --git a/galen-core/src/main/java/com/galenframework/reports/GalenTestInfo.java b/galen-core/src/main/java/com/galenframework/reports/GalenTestInfo.java
@@ -23,7 +23,6 @@
 
 import com.galenframework.tests.GalenEmptyTest;
 import com.galenframework.tests.GalenTest;
-import com.sun.org.apache.xpath.internal.operations.Bool;
 import org.apache.commons.lang3.StringEscapeUtils;
 
 public class GalenTestInfo {

diff --git a/galen-core/src/test/java/com/galenframework/components/mocks/driver/MockedPageItem.java b/galen-core/src/test/java/com/galenframework/components/mocks/driver/MockedPageItem.java
@@ -74,7 +74,7 @@ public void setArea(Integer[] area) {
 
     public boolean matches(By by) {
         if (by instanceof By.ByCssSelector) {
-            String selector = (String)takeFieldValueViaReflection(by, "selector");
+            String selector = (String)takeFieldValueViaReflection(by, "cssSelector");
             if("css".equals(getLocatorType()) && selector.equals(getLocatorValue()) ) {
                 return true;
             }

diff --git a/pom.xml b/pom.xml
@@ -30,7 +30,7 @@
     <sonatypeOssDistMgmtSnapshotsUrl>https://oss.sonatype.org/content/repositories/snapshots/</sonatypeOssDistMgmtSnapshotsUrl>
 
     <!-- VERSION NUMBERS -->
-    <selenium.version>3.11.0</selenium.version>
+    <selenium.version>3.14.0</selenium.version>
     <commons-io.version>2.4</commons-io.version>
     <commons-cli.version>1.2</commons-cli.version>
     <phantomjsdriver.version>1.2.1</phantomjsdriver.version>