Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROCm] Add ROCm tuning config to block gemm and Re-tune for AMD Radeon Graphics #3418

Merged
merged 13 commits into from
Feb 11, 2025

Conversation

BruceXcluding
Copy link
Contributor

Motivation

Add ROCm block gemm tuning configs

Modifications

Modify config tunings for AMD Radeon Graphics

Checklist

  • Format your code according to the Code Formatting with Pre-Commit.
  • Add unit tests as outlined in the Running Unit Tests.
  • Update documentation / docstrings / example tutorials as needed, according to Writing Documentation.
  • Provide throughput / latency benchmark results and accuracy evaluation results as needed, according to Benchmark and Profiling and Accuracy Results.
  • For reviewers: If you haven't made any contributions to this PR and are only assisting with merging the main branch, please remove yourself as a co-author when merging the PR.

@BruceXcluding
Copy link
Contributor Author

cc @HaiShaw

@BruceXcluding BruceXcluding changed the title [ROCm] Add ROCm tuning config to block gemm and Re-tune block gemm for AMD Radeon Graphics [ROCm] Add ROCm tuning config to block gemm and Re-tune for AMD Radeon Graphics Feb 9, 2025
Copy link
Collaborator

@HaiShaw HaiShaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BruceXcluding LGTM, do we notice performance regression on MI300X?

@fsx950223
Copy link

fsx950223 commented Feb 9, 2025

Device names in the config seems wrong.

@BruceXcluding
Copy link
Contributor Author

Device names in the config seems wrong.

This is not used by MI300X

@fsx950223
Copy link

fsx950223 commented Feb 9, 2025

Device names in the config seems wrong.

This is not used by MI300X

It's a general device name for amd gpus. Mi308 config may mix with other gpu config.

@BruceXcluding BruceXcluding marked this pull request as ready for review February 9, 2025 10:45
@BruceXcluding
Copy link
Contributor Author

Device names in the config seems wrong.

This is not used by MI300X

It's a general device name for amd gpus. Mi308 config may mix with other gpu config.

Actually not, but you may manually modify the device name or re-tune for local machine.

@HaiShaw HaiShaw merged commit fdf04a1 into sgl-project:main Feb 11, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants