Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hail SVCR local alleles #5

Closed
hammer opened this issue Jan 11, 2024 · 3 comments · Fixed by #110
Closed

Hail SVCR local alleles #5

hammer opened this issue Jan 11, 2024 · 3 comments · Fixed by #110

Comments

@hammer
Copy link

hammer commented Jan 11, 2024

Hail’s multi-sample storage strategy gets a preprint: https://www.biorxiv.org/content/10.1101/2024.01.09.574205v1

I’m not sure this changes much for our paper though we should probably point to it in the discussion and also look into mapping it onto Zarr someday!

@jeromekelleher
Copy link
Contributor

Interesting - agree we should discuss, and it doesn't really change our narrative

@jeromekelleher
Copy link
Contributor

Noting here the the "local alleles" idea from SVCR is a elegant and powerful idea that we should adopt. I'm currently working on VCF conversion, and the PL fields are a serious challenge to the current model. I've got a 1000 genomes example here:

 "shape": [  
        2958525,
        3202,
        28
    ],      

which is pretty impractical.

@jeromekelleher jeromekelleher transferred this issue from sgkit-dev/sgkit-publication Mar 5, 2024
@jeromekelleher jeromekelleher transferred this issue from another repository Mar 6, 2024
@hammer hammer changed the title SVCR Hail SVCR local alleles Mar 24, 2024
@jeromekelleher
Copy link
Contributor

Local alleles has also been implemented in bcftools apparently, as mentioned in discuss of the VCF perspective: https://academic.oup.com/gigascience/article/10/2/giab008/6137722

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants