Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test for more restrictive xarray multi-index #854

Merged
merged 1 commit into from
May 9, 2022
Merged

Fix test for more restrictive xarray multi-index #854

merged 1 commit into from
May 9, 2022

Conversation

tomwhite
Copy link
Collaborator

@tomwhite tomwhite commented May 6, 2022

Fixes #850

@tomwhite
Copy link
Collaborator Author

tomwhite commented May 6, 2022

Xarray multi-indexes must now share the same (single) dimension. This PR changes the test accordingly.

@tomwhite
Copy link
Collaborator Author

tomwhite commented May 6, 2022

I checked this against upstream xarray and it passes the tests.

@tomwhite tomwhite added the auto-merge Auto merge label for mergify test flight label May 9, 2022
@mergify mergify bot merged commit 926e7ce into sgkit-dev:main May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromekelleher jeromekelleher jeromekelleher approved these changes

Assignees
No one assigned
Labels
auto-merge Auto merge label for mergify test flight
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upstream xarray causing build to fail with "ValueError: unmatched dimensions for multi-index variables"
2 participants
@tomwhite @jeromekelleher