Fix for webpacker issue 2071 #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgara
force-pushed
the
add-webpacker-switch
branch
4 times, most recently
from
9093bbe to
09fcdfb
Compare
sgara
force-pushed
the
add-webpacker-switch
branch
2 times, most recently
from
de888e3 to
8c89173
Compare
sgara
force-pushed
the
add-webpacker-switch
branch
6 times, most recently
from
c7729ae to
8c5ed9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Stéphane!
Thanks a lot for you work, adding Webpacker to ActiveAdmin. It is really what I needed, and I hope it gets merged soon.
I did find an issue, not very obvious, but it manifest itself on deployment. This is the problem: rails/webpacker#2071.
Which means that Webpacker sticks the stylesheets in the Javascript packs, and the presence of the stylesheets link causes an Exception. I added a very simple change just to avoid generating the stylesheets link if the Webpacker is set to be used.
I hope this is helpful for others as it is was for me.
Thanks!