fix: Force sun.jnu.encoding to be UTF-8 in images
#514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency ReviewThe following issues were found:
Snapshot WarningsRe-running this action after a short time may resolve the issue. See the documentation for more information and troubleshooting advice. License Issuespom.xml
OpenSSF ScorecardScorecard details
Scanned Manifest Filespom.xml
|
Images pick up `sun.jnu.encoding` from the host build environment, which thus needs to be UTF-8 to be able to access paths with non-ASCII characters in them on Linux. Since Bazel does not inherit `LC_CTYPE` from the host, the JVM would otherwise default to an ASCII locale. Signed-off-by: Fabian Meumertzheim <[email protected]>
|
|
@sgammon Looks like the sha for GraalVM 23 changed, do you happen to know why? |
|
@fmeum GraalVM posts "archive" and "latest" URLs; the archive URLs are not available immediately after release. It is expected as I don't think we've had a release since v23 initially came out. |
sgammon
approved these changes
Dec 4, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #514 +/- ##
=====================================
Coverage ? 0
=====================================
Files ? 0
Lines ? 0
Branches ? 0
=====================================
Hits ? 0
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. |
copybara-service bot
pushed a commit
to bazelbuild/bazel
that referenced
this pull request
Dec 6, 2024
This requires patching rules_graalvm with sgammon/rules_graalvm#514 to ensure the native image runs with `sun.jnu.encoding` set to `UTF-8` on Linux. Also enable unrelated tests after the recent java_tools update. Work towards #24444 Unblocks #24457 Closes #24565. PiperOrigin-RevId: 703409662 Change-Id: I44de4387de4a6da404436f5a35a2b27274122bbb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Images pick up
sun.jnu.encodingfrom the host build environment, which thus needs to be UTF-8 to be able to access paths with non-ASCII characters in them on Linux. Since Bazel does not inheritLC_CTYPEfrom the host, the JVM would otherwise default to an ASCII locale.