fix(windows): added use_param_file for args
#132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sam Gammon <[email protected]>
sgammon
added
bug
|
Kudos, SonarCloud Quality Gate passed!
|
|
@ruwi-next Very sorry about the PR mixup! I'll get this merged and included in the upcoming |
|
No worries, thanks for such a quick response. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, firstly thanks for making this project.
I am using it on windows and was running into an issue where the command used to invoke native-image was too long for windows. It turns out graalvm added support for args files here graalvm/native-build-tools#205 and it wasn't too hard to add support for them here.
Thanks
Ruairidh
cc / @ruwi-next