Skip to content

Commit

Permalink
fix: rollback use_default_shell_env, remove msvc vars from tests
Browse files Browse the repository at this point in the history
Signed-off-by: Sam Gammon <[email protected]>
  • Loading branch information
sgammon committed Sep 1, 2023
1 parent 2ae10ac commit 2bcde23
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 11 deletions.
5 changes: 1 addition & 4 deletions example/integration_tests/bazel5/.bazelrc
Original file line number Diff line number Diff line change
@@ -1,4 +1 @@
# Need these env vars on Windows
build --action_env=INCLUDE
build --action_env=MSVC
build --action_env=LIB
# Nothing at this time.
5 changes: 1 addition & 4 deletions example/integration_tests/bazel6/.bazelrc
Original file line number Diff line number Diff line change
@@ -1,4 +1 @@
# Need these env vars on Windows
build --action_env=INCLUDE
build --action_env=MSVC
build --action_env=LIB
# Nothing at this time.
3 changes: 0 additions & 3 deletions internal/native_image/rules.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -115,9 +115,6 @@ def _graal_binary_implementation(ctx):
)

else:
# activate default shell environment on windows and linux
run_params["use_default_shell_env"] = True

# run our proxied env shim on all other platforms.
graal_actions.run(
arguments = [args],
Expand Down

0 comments on commit 2bcde23

Please sign in to comment.