Remove arrow2 from Connector-X #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wangxiaoying For your review! |
There was a problem hiding this comment.
Thanks @EricFecteau , I think the PR looks great!
Since this PR would remove arrow2 completely, I'm considering to have a new stable release first. I will come back and merge it after the release.
|
Yeah I think that makes a lot of sense! I think it should be a major version bump for both Rust and Python. |
|
v0.4.1 is released (with both arrow and arrow2) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes Arrow2, a deprecated crate, from Connector-X. See discussion here: #720
I verified that all functionality were at parity for all sources. Postgres was missing Enums (implemented for Arrow2 but not Arrow) and I implemented it for Arrow.