Create input form #26

yusuke-sforzando · 2020-11-20T11:41:29Z

Describe the PR

To close #9 .
Request input text value to GET /search.

Screenshots

`index.html` with no error

`search.html` on success

Detail of the change

index.html
- Show title "Registration of equipment and books"
- Show label "Enter one of the following keywords: keyword, ISBN code, or ASIN code"
- Putting up a text input form
- Putting up a submit button showed「Search」
- GET the string in the input form to /search when the submit button is pressed
search.html
- The string to be GETed is displayed as is

Anticipated impacts

None.

To reproduce

Run python main.py
Visit to http://0.0.0.0:8888/
Make sure the screen is displayed as shown in the screenshot
Type in the appropriate string and press the search button
Make sure you see the string you entered

Additional context

CSS implemented in Issue #18

Next issue is #11

codecov · 2020-11-20T14:37:46Z

Codecov Report

Merging #26 (fd33994) into main (0dbd2e4) will increase coverage by 1.88%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
+ Coverage   79.01%   80.89%   +1.88%     
==========================================
  Files           4        4              
  Lines          81       89       +8     
  Branches        6        7       +1     
==========================================
+ Hits           64       72       +8     
  Misses         12       12              
  Partials        5        5

Impacted Files	Coverage Δ
main.py	`88.23% <100.00%> (+10.45%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dbd2e4...fd33994. Read the comment docs.

main.py

templates/index.html

main.py

templates/index.html

templates/search-result.html

main.py

tomoya-sforzando · 2020-11-21T07:39:05Z

main.py

+    app.logger.info("search_result(): GET /")
+    keyword = request.args.get("input_keyword", "")
+    if keyword:
+        return render_template("search-result.html", keyword=keyword)


元あった context_dict を活かして、keyword を追加する方が良いかな。
なぜなら、この後context_dictには、Amazon PA-APIで取得した結果とか、default_positionsとかそう言うのが追加されていくことが想定できるから。

確かにそうですね。
修正します。

main.py

templates/index.html

main.py

templates/index.html

yusuke-sforzando · 2020-11-25T07:05:57Z

失礼しました。
修正します。

tomoya-sforzando · 2020-11-25T08:04:22Z

templates/search.html

+{% extends "_base.html" %}
+{% block main %}
+  <h1>Search Result</h1>
+  <h2>Keyword: {{ keyword }}</h2>


Flash messageを実装したらそもそもTopページにリダイレクトさせてからのメッセージ表示とかにできたらと思っているのだけど、

現時点では、messageが表示される = Keyword がないというない状況で、keyword: と表示されているのは変だから、

{% if not message %} <h2>Keyword: {{ keyword }}</h2> {% endif %}

の場合分けをするのはどうでしょうか？

そうですね。その方が良いですね。
修正します。

いや、むしろ index.html に戻してあげなよ。message付きで。

なるほどですね。
そうですね、そちらの方がユーザーファーストなのでそちらでやってみます。

index.html がレンダーされた、と言うテストが必要なのでは？

こちらもそうですね。
追記します。

tomoya-sforzando · 2020-11-26T05:48:12Z

main.py

-        "message": "This is dummy message."
+        "subtitle": f"Search Result for {keyword}",
+        "keyword": keyword,
+        "message": None if keyword else "Enter keywords back on the top page."


index.htmlで表示されるメッセージなら、文章としては、"Enter any keywords." で良さそうですね

そうですね。
修正します。

tomoya-sforzando · 2020-11-26T05:49:32Z

main.py


 from __init__ import app

+app.secret_key = "aasss"


このPRでは、不要と思います。

そうですね、修正します。

shin-sforzando · 2020-11-26T06:49:51Z

main.py

+    if keyword:
+        return render_template("search.html", **context_dict)
+    else:
+        return render_template("index.html", **context_dict)


これでは index.html の title が Search Result for になります。

そうですね。
context_dictのsubtitleを変更するコードを追記します。

shin-sforzando · 2020-11-26T06:50:54Z

templates/index.html

@@ -1,3 +1,9 @@
 {% extends "_base.html" %}
 {% block main %}
+  <h1>Registration of equipment and books</h1>
+  <form action="/search" method="get">
+    <label for="query">Enter one of the following keywords: keyword, ISBN code, or ASIN code </label>


英文なんだから末尾にピリオドが要りますよね。

失礼しました。追記します。

shin-sforzando · 2020-11-26T06:51:57Z

templates/search.html

+{% extends "_base.html" %}
+{% block main %}
+  <h1>Search Result</h1>
+  <h2>Keyword: {{ keyword }}</h2>


index.html がレンダーされた、と言うテストが必要なのでは？

shin-sforzando · 2020-11-26T07:43:03Z

main.py

+    if keyword:
+        return render_template("search.html", **context_dict)
+    else:
+        context_dict["subtitle"] = "a service to quickly register equipments and books."


q-lako/templates/_base.html

Line 7 in b47d07d

<title>q-lako - {{ subtitle | default("a service to quickly register equipments and books") }}</title>

にて default が設定されてるので要らないです。

承知しました！修正します！

shin-sforzando · 2020-11-26T07:44:35Z

main.py

+@app.route("/search", methods=["GET"])
+def search():
+    app.logger.info(f"search(): GET {request.full_path}.")
+    keyword = request.args.get("query", None)
    context_dict = {


keyword の有無で処理が変わるので、
それぞれのif文の中でそれぞれに必要最低限の context_dict を作った方が良さそう。

なるほどですね。
承知しました、修正します！

tomoya-sforzando

確認しました

yusuke-sforzando added 2 commits November 20, 2020 20:27

👍 Add title and subtitle for index.html

9ac2894

✨ Add form for index.html

8f6cb62

yusuke-sforzando added the enhancement New feature or request label Nov 20, 2020

yusuke-sforzando added this to the Version 0.9 milestone Nov 20, 2020

yusuke-sforzando requested review from shin-sforzando and tomoya-sforzando November 20, 2020 11:41

yusuke-sforzando self-assigned this Nov 20, 2020

✨ Improve main.py and index.html by form.get

8886f23

yusuke-sforzando added 5 commits November 21, 2020 03:19

✨ Improve main.py by session

0eefc68

✨Remove api key

0105455

✨Use app secret key

c1cd94e

👍 Improve secret key by app secret key

59fdc0d

👍 Imorove test_main.py for search result

4f1963b

tomoya-sforzando reviewed Nov 21, 2020

View reviewed changes

tomoya-sforzando and others added 7 commits November 21, 2020 15:02

👍 Add tests for search-result

c936eee

🔧 Update test for search-result

9e15b60

👍 Imrove main.py for test_main.py

4e5f0c4

📝 Remove template file name

378c919

📝 Rename html tag p to label

b4ae448

📝 Check gpg

93d857d

📝 Improve .env.gpg

e457dfa

yusuke-sforzando marked this pull request as ready for review November 21, 2020 07:26

tomoya-sforzando suggested changes Nov 21, 2020

View reviewed changes

yusuke-sforzando added 2 commits November 21, 2020 16:57

👍 Improve main.py for use context_dict

75529d3

📝 Modify index.html for use input_keyword

86fc943

yusuke-sforzando requested a review from tomoya-sforzando November 21, 2020 08:00

tomoya-sforzando reviewed Nov 21, 2020

View reviewed changes

main.py Outdated Show resolved Hide resolved

main.py Outdated Show resolved Hide resolved

main.py Outdated Show resolved Hide resolved

templates/index.html Outdated Show resolved Hide resolved

yusuke-sforzando added 3 commits November 25, 2020 16:28

👍 Improve base.html for display message

18e74ee

♻️ Format code for html file

87fde39

🎨 Insert a blank line for base.html

0dcd3ee

yusuke-sforzando requested a review from shin-sforzando November 25, 2020 08:00

tomoya-sforzando reviewed Nov 25, 2020

View reviewed changes

👍 Improve search.html for no-keyword

909e0a9

yusuke-sforzando requested a review from tomoya-sforzando November 25, 2020 08:09

yusuke-sforzando added 4 commits November 26, 2020 11:38

✨ Improve mai.py for no-search-word

a9678a1

💢 Merge improment heeder

447a083

♻️ Format code

51ec344

📝 Improve base.html for desplay message

7990ff9

tomoya-sforzando reviewed Nov 26, 2020

View reviewed changes

yusuke-sforzando added 2 commits November 26, 2020 14:51

📝 Improve main.py for message

ded703b

♻️ Improve message for test_main.py

cb5edd7

yusuke-sforzando requested a review from tomoya-sforzando November 26, 2020 06:44

shin-sforzando suggested changes Nov 26, 2020

View reviewed changes

yusuke-sforzando added 3 commits November 26, 2020 16:26

✨ Add not inputed_query for test_main.py

dec680d

🔥 Remove flask_session directory

b47d07d

🔥 Remove flask_session for .gitignore

7e379ca

shin-sforzando suggested changes Nov 26, 2020

View reviewed changes

✨ Improve context_dict for main.py

fd33994

shin-sforzando approved these changes Nov 26, 2020

View reviewed changes

tomoya-sforzando approved these changes Nov 26, 2020

View reviewed changes

tomoya-sforzando merged commit 5ea5ed6 into main Nov 26, 2020

tomoya-sforzando deleted the 009_Create_input_form branch November 26, 2020 08:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create input form #26

Create input form #26

yusuke-sforzando commented Nov 20, 2020 •

edited by shin-sforzando

Loading

codecov bot commented Nov 20, 2020 •

edited

Loading

tomoya-sforzando Nov 21, 2020

yusuke-sforzando Nov 21, 2020

yusuke-sforzando commented Nov 25, 2020

tomoya-sforzando Nov 25, 2020

yusuke-sforzando Nov 25, 2020

shin-sforzando Nov 25, 2020

yusuke-sforzando Nov 25, 2020

shin-sforzando Nov 26, 2020

yusuke-sforzando Nov 26, 2020

tomoya-sforzando Nov 26, 2020

yusuke-sforzando Nov 26, 2020

tomoya-sforzando Nov 26, 2020

yusuke-sforzando Nov 26, 2020

shin-sforzando Nov 26, 2020

yusuke-sforzando Nov 26, 2020

shin-sforzando Nov 26, 2020

yusuke-sforzando Nov 26, 2020

shin-sforzando Nov 26, 2020

shin-sforzando Nov 26, 2020

yusuke-sforzando Nov 26, 2020

shin-sforzando Nov 26, 2020

yusuke-sforzando Nov 26, 2020

tomoya-sforzando left a comment

Create input form #26

Create input form #26

Conversation

yusuke-sforzando commented Nov 20, 2020 • edited by shin-sforzando Loading

Describe the PR

Screenshots

index.html with no error

search.html on success

Detail of the change

Anticipated impacts

To reproduce

Additional context

codecov bot commented Nov 20, 2020 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yusuke-sforzando commented Nov 25, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tomoya-sforzando left a comment

Choose a reason for hiding this comment

yusuke-sforzando commented Nov 20, 2020 •

edited by shin-sforzando

Loading

`index.html` with no error

`search.html` on success

codecov bot commented Nov 20, 2020 •

edited

Loading