Skip to content

Commit

Permalink
refactor: Removes the Filter Box code (apache#26328)
Browse files Browse the repository at this point in the history
Co-authored-by: John Bodley <[email protected]>
  • Loading branch information
2 people authored and sfirke committed Mar 22, 2024
1 parent e54df27 commit 1d22ac4
Show file tree
Hide file tree
Showing 97 changed files with 577 additions and 4,970 deletions.
1 change: 1 addition & 0 deletions UPDATING.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ assists people when migrating to a new version.

### Breaking Changes

- [26328](https://github.com/apache/superset/issues/26328): Removes the deprecated Filter Box code and it's associated dependencies `react-select` and `array-move`. It also removes the `DeprecatedSelect` and `AsyncSelect` components that were exclusively used by filter boxes. Existing filter boxes will be automatically migrated to native filters.
- [26330](https://github.com/apache/superset/issues/26330): Removes the deprecated `DASHBOARD_FILTERS_EXPERIMENTAL` feature flag. The previous value of the feature flag was `False` and now the feature is permanently removed.
- [26344](https://github.com/apache/superset/issues/26344): Removes the deprecated `ENABLE_EXPLORE_JSON_CSRF_PROTECTION` feature flag. The previous value of the feature flag was `False` and now the feature is permanently removed.
- [26345](https://github.com/apache/superset/issues/26345): Removes the deprecated `ENABLE_TEMPLATE_REMOVE_FILTERS` feature flag. The previous value of the feature flag was `True` and now the feature is permanently enabled.
Expand Down
94 changes: 0 additions & 94 deletions docs/docs/miscellaneous/native-filter-migration.mdx

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ describe('Dashboard tabs', () => {
cy.get('.Select__control').first().should('be.visible').click();
cy.get('.Select__control input[type=text]').first().focus().type('South');
cy.get('.Select__option').contains('South Asia').click();
cy.get('.filter_box button:not(:disabled)').contains('Apply').click();
cy.get('.filter button:not(:disabled)').contains('Apply').click();

// send new query from same tab
cy.wait(treemapAlias).then(({ request }) => {
Expand Down Expand Up @@ -149,7 +149,7 @@ describe('Dashboard tabs', () => {
cy.get('.ant-tabs-tab').contains('row tab 1').click();

cy.get('.Select__clear-indicator').click();
cy.get('.filter_box button:not(:disabled)').contains('Apply').click();
cy.get('.filter button:not(:disabled)').contains('Apply').click();

// trigger 1 new query
waitForChartLoad(TREEMAP);
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,9 @@ describe('Test explore links', () => {
cy.url().then(() => {
cy.get('[data-test="query-save-button"]').click();
cy.get('[data-test="saveas-radio"]').check();
cy.get('[data-test="new-chart-name"]').type(newChartName);
cy.get('[data-test="new-chart-name"]').type(newChartName, {
force: true,
});
cy.get('[data-test="btn-modal-save"]').click();
cy.verifySliceSuccess({ waitAlias: '@tableChartData' });
cy.visitChartByName(newChartName);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -657,7 +657,7 @@ export const dashboardView = {
treeMapChartModal: {
selectItem: '.Select_control',
selectItemInput: '.Select__control input[type=text]',
applyButton: '.filter_box button:not(:disabled)',
applyButton: '.filter button:not(:disabled)',
clearItemIcon: '.Select__clear-indicator',
},
sliceThreeDots: '[aria-label="More Options"]',
Expand Down
54 changes: 7 additions & 47 deletions superset-frontend/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 1d22ac4

Please sign in to comment.