Remove Ruby 1.8 and 1.9 support for 5-stable #798
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rake requires 1.9+: ruby/rake#86 tins requires 2.0+: flori/tins@9ebb625
aycabta
changed the title
aycabta
changed the title
aycabta
changed the title
|
I backported video support to v5 from v6. But I have yet to create new Pull Request with the branch, because this Pull Request hasn't be merged. The branch passed test, but except for RuboCop (Ruby: 2.0.0 and Ruby: 2.1). It contains uploading multiple images. Please check this Pull Request out first. |
|
OK, I fixed errors of RuboCop. |
|
The backport-video-support-from-v6 is fixed about errors of RuboCop |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request failed with RuboCop, should I fix it too?