Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streaming API #49

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Streaming API #49

wants to merge 4 commits into from

Conversation

vladfaust
Copy link
Contributor

Don't merge for now, there is an issue crystal-lang/crystal#4991, which may be related to this client implementation

@kenta-s kenta-s mentioned this pull request Sep 19, 2017
Closed
@mamantoha
Copy link
Contributor

Hi @kenta-s, @vladfaust.
Is there any chance that PR will be merged?

@alexanderadam
Copy link

@mamantoha I'm afraid the mentioned issue isn't resolved yet.

@vladfaust
Copy link
Contributor Author

Yes, currently the streaming client may eventually crash the program in non-reacuable manner. I managed to restart the containing application every 10 minutes, it’s the only workaround.

Don’t know what to do with this PR though. Maybe there is another way to implement Streaming API.

@mamantoha
Copy link
Contributor

I prefer that this PR stay open. Anyone can see that this functionality has been implemented but does not work as it should.

@vladfaust can you provide an example of how to reproduce program's crash?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vladfaust @mamantoha @alexanderadam